Fix a string type issue with Subversion patch output.

 






 

 


  Review Request #12534
  —
  Created Aug. 15, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-3.x
 









 
 

  4973
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
When applying patches for Subversion on Python 3, a Unicode string was

being returned instead of a byte string, causing a crash when trying to

output the results.


The cause was a missing results_unicode=False, which has been added,

along with unit tests checking for most of the patching functionality.

 








  


 
 

  
Unit tests pass.


Manually verified the fix.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix a string type issue with Subversion patch output.
     
When applying patches for Subversion on Python 3, a Unicode string was
being returned instead of a byte string, causing a crash when trying to
output the results.

The cause was a missing `results_unicode=False`, which has been added,
along with unit tests checking for most of the patching functionality.

    

   
  		
  4230ecf24a05f4ea536614c470c0d01f49e67fff
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/svn.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_svn.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...