Summary

Fix a string type issue with Subversion patch output.

Review Request #12534 — Created Aug. 15, 2022 and submitted Aug. 15, 2022, 7:11 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-3.x

Bugs

4973

Depends On

Reviewers

Groups

rbtools

People

Description

When applying patches for Subversion on Python 3, a Unicode string was
being returned instead of a byte string, causing a crash when trying to
output the results.

The cause was a missing results_unicode=False, which has been added,
along with unit tests checking for most of the patching functionality.

Testing Done

Unit tests pass.

Manually verified the fix.

Commits

Summary	ID
Fix a string type issue with Subversion patch output. When applying patches for Subversion on Python 3, a Unicode string was being returned instead of a byte string, causing a crash when trying to output the results. The cause was a missing `results_unicode=False`, which has been added, along with unit tests checking for most of the patching functionality.	4230ecf24a05f4ea536614c470c0d01f49e67fff

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (14b3b24)