Improve output when scanning for a usable client.

Review Request #12512 — Created Aug. 8, 2022 and submitted

chipx86
RBTools
release-4.x
rbtools

This rewords some of the output when trying to scan for a usable client
but failing to find anything. It aims to add context to the messages,
helping to see the input (repository type or URL) that led to the error,
and to add instructions to help resolve the issue (saying to check for a
.reviewboardrc, what it should contain, and pointing users to
rbt setup-repo).

The work here is just a base for upcoming work on this logic to clean
things up and to provide error reporting that works with the upcoming
formal SCMClient dependency support.

Tested all the error/warning conditions, verifying the output.

Summary
Improve output when scanning for a usable client.
Description From Last Updated

Can we say "could not" instead of "couldn't"? I feel like it reads better.

daviddavid

Same here.

daviddavid

This can use single quotes.

daviddavid
david
  1. 
      
  2. rbtools/clients/__init__.py (Diff revision 1)
     
     

    Can we say "could not" instead of "couldn't"? I feel like it reads better.

    1. Updating these to use "was not" to be in line with other logs here.

  3. rbtools/clients/__init__.py (Diff revision 1)
     
     

    Same here.

  4. rbtools/clients/__init__.py (Diff revision 1)
     
     
     
     
     
     
     
     

    This can use single quotes.

  5. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (9b34e23)
Loading...