Update the Subversion unit tests to use build_client() and clean up tests.

Review Request #12511 — Created Aug. 8, 2022 and submitted

Information

RBTools
release-3.x

Reviewers

This updates the Subversion unit tests to build a SCNClient in each
test where it's needed, rather than in setUp(). This is in prepration
for new tests that will need to handle client construction differently.

This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.

We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.

It also fixes up diff checking to compare for content and not just a
hash, for each version of Subversion where we previously compared
hashes. This will be important for work on supporting alternative diff
tools.

Subversion unit tests pass.

Summary ID
Update the Subversion unit tests to use build_client() and clean up tests.
This updates the Subversion unit tests to build a `SCNClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash, for each version of Subversion where we previously compared hashes. This will be important for work on supporting alternative diff tools.
0844062a2d63dcdefcf248ab9266e6262d8917bb
Description From Last Updated

local variable 'svn_version_parts' is assigned to but never used Column: 9 Error code: F841

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (9d81fa6)