Summary

Update the Subversion unit tests to use build_client() and clean up tests.

Review Request #12511 — Created Aug. 8, 2022 and submitted Aug. 14, 2022, 7:53 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This updates the Subversion unit tests to build a SCNClient in each
test where it's needed, rather than in setUp(). This is in prepration
for new tests that will need to handle client construction differently.

This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.

We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.

It also fixes up diff checking to compare for content and not just a
hash, for each version of Subversion where we previously compared
hashes. This will be important for work on supporting alternative diff
tools.

Testing Done

Subversion unit tests pass.

Commits

Summary	ID
Update the Subversion unit tests to use build_client() and clean up tests. This updates the Subversion unit tests to build a `SCNClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash, for each version of Subversion where we previously compared hashes. This will be important for work on supporting alternative diff tools.	0844062a2d63dcdefcf248ab9266e6262d8917bb

Summary

Update the Subversion unit tests to use build_client() and clean up tests.

This updates the Subversion unit tests to build a `SCNClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash, for each version of Subversion where we previously compared hashes. This will be important for work on supporting alternative diff tools.

0844062a2d63dcdefcf248ab9266e6262d8917bb

Issues

Description	From	Last Updated
local variable 'svn_version_parts' is assigned to but never used Column: 9 Error code: F841	reviewbot	Aug. 8, 2022, 1:56 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_svn.py (Diff revision 1)

The issue has been resolved. Show all issues

local variable 'svn_version_parts' is assigned to but never used

Column: 9
Error code: F841

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Update the Subversion unit tests to use build_client() and clean up tests. This updates the Subversion unit tests to build a `SCNClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash, for each version of Subversion where we previously compared hashes. This will be important for work on supporting alternative diff tools.	4ec8133ba25f1921a3835a5a6dbb63c0f6bbe123
	Update the Subversion unit tests to use build_client() and clean up tests. This updates the Subversion unit tests to build a `SCNClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash, for each version of Subversion where we previously compared hashes. This will be important for work on supporting alternative diff tools.	0844062a2d63dcdefcf248ab9266e6262d8917bb

Diff:

Revision 2 (+1054 -588)

Show changes

rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (9d81fa6)