Update the Subversion unit tests to use build_client() and clean up tests.
Review Request #12511 — Created Aug. 8, 2022 and submitted
This updates the Subversion unit tests to build a
SCNClient
in each
test where it's needed, rather than insetUp()
. This is in prepration
for new tests that will need to handle client construction differently.This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.It also fixes up diff checking to compare for content and not just a
hash, for each version of Subversion where we previously compared
hashes. This will be important for work on supporting alternative diff
tools.
Subversion unit tests pass.
Summary | ID |
---|---|
0844062a2d63dcdefcf248ab9266e6262d8917bb |
Description | From | Last Updated |
---|---|---|
local variable 'svn_version_parts' is assigned to but never used Column: 9 Error code: F841 |
reviewbot |
- Change Summary:
-
Removed an unused variable.
- Commits:
-
Summary ID 4ec8133ba25f1921a3835a5a6dbb63c0f6bbe123 0844062a2d63dcdefcf248ab9266e6262d8917bb - Diff:
-
Revision 2 (+1054 -588)