Update the Perforce unit tests to use build_client() and clean up tests.

Review Request #12509 — Created Aug. 5, 2022 and submitted

chipx86
RBTools
release-4.x
rbtools

This updates the Perforce unit tests to build a PerforceClient in
each test where it's needed, rather than in setUp(). This is in
prepration for new tests that will need to handle client construction
differently.

This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.

We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.

It also fixes up diff checking to compare for content and not just a
hash. This will be important for work on supporting alternative diff
tools.

All Perforce unit tests pass.

Summary
Update the Perforce unit tests to use build_client() and clean up tests.
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (2bfd342)
Loading...