Summary

Update the Perforce unit tests to use build_client() and clean up tests.

Review Request #12509 — Created Aug. 5, 2022 and submitted Aug. 14, 2022, 7:53 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This updates the Perforce unit tests to build a PerforceClient in
each test where it's needed, rather than in setUp(). This is in
prepration for new tests that will need to handle client construction
differently.

This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.

We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.

It also fixes up diff checking to compare for content and not just a
hash. This will be important for work on supporting alternative diff
tools.

Testing Done

All Perforce unit tests pass.

Commits

Summary	ID
Update the Perforce unit tests to use build_client() and clean up tests. This updates the Perforce unit tests to build a `PerforceClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash. This will be important for work on supporting alternative diff tools.	2117b0e8565585fe079b38662a836e32f87aafcd

Summary

Update the Perforce unit tests to use build_client() and clean up tests.

This updates the Perforce unit tests to build a `PerforceClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash. This will be important for work on supporting alternative diff tools.

2117b0e8565585fe079b38662a836e32f87aafcd

flake8 passed.

JSHint passed.

Change Summary:

Updated to target RBTools 4.0.

Commits:

	Summary	ID
	Update the Perforce unit tests to use build_client() and clean up tests. This updates the Perforce unit tests to build a `PerforceClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash. This will be important for work on supporting alternative diff tools.	823176be52efb17ab153e850d7172ae7567ecd15
	Update the Perforce unit tests to use build_client() and clean up tests. This updates the Perforce unit tests to build a `PerforceClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. It also fixes up diff checking to compare for content and not just a hash. This will be important for work on supporting alternative diff tools.	2117b0e8565585fe079b38662a836e32f87aafcd

Branch:

release-3.x

release-4.x

Diff:

Revision 2 (+470 -268)

Show changes

rbtools/clients/tests/test_p4.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (2bfd342)