Summary

Add new API endpoints for managing repository ACLs.

Review Request #12489 — Created July 27, 2022 and submitted Aug. 9, 2022, 12:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

One thing we've had requests for over the years is a way to manage
repository ACLs via scripts or other automation. This change adds two
new API endpoints for these. These are both children of the repository
resource, and work similarly to the existing group member resource.

Testing Done


Ran unit tests.
Made a variety of API requests to manage repository ACLs.

Commits

Summary	ID
Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	6fbe71286e709ee3851b6667d227d79d0ce859ad

Summary

Add new API endpoints for managing repository ACLs.

One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.

6fbe71286e709ee3851b6667d227d79d0ce859ad

Issues

Description	From	Last Updated
'djblets.util.decorators.augment_method_from' imported but unused Column: 1 Error code: F401	reviewbot	July 27, 2022, 3:04 p.m.
'reviewboard.scmtools.models.Repository' imported but unused Column: 1 Error code: F401	reviewbot	July 27, 2022, 3:04 p.m.
local variable 'local_site' is assigned to but never used Column: 9 Error code: F841	reviewbot	July 27, 2022, 3:04 p.m.
'reviewboard.scmtools.models.Repository' imported but unused Column: 1 Error code: F401	reviewbot	July 27, 2022, 3:04 p.m.
local variable 'local_site' is assigned to but never used Column: 9 Error code: F841	reviewbot	July 27, 2022, 3:04 p.m.
too many blank lines (3) Column: 1 Error code: E303	reviewbot	July 27, 2022, 3:04 p.m.
local variable 'user' is assigned to but never used Column: 9 Error code: F841	reviewbot	July 27, 2022, 3:04 p.m.
expected 2 blank lines, found 1 Column: 1 Error code: E302	reviewbot	July 27, 2022, 3:04 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	July 27, 2022, 3:04 p.m.
This will have to be 4.0.11 now. Sorry :/ Same in other places.	chipx86	July 29, 2022, 2:02 p.m.
These should be swapped.	chipx86	July 29, 2022, 2:02 p.m.
Missing , optional.	chipx86	July 29, 2022, 2:03 p.m.
For future-proofing, let's pass in request as a keyword argument.	chipx86	July 29, 2022, 2:03 p.m.
Missing , unused	maubin	July 29, 2022, 2:06 p.m.
Why not use repository.is_accessible_by here? Same with the other has_access_permissions and has_list_access_permissions methods.	maubin	July 29, 2022, 2:02 p.m.
We could just pass local_site_name as a keyword argument.	chipx86	July 29, 2022, 2:04 p.m.
These should be swapped.	chipx86	July 29, 2022, 2:02 p.m.
Missing , optional.	chipx86	July 29, 2022, 2:04 p.m.
Same as above, let's do request=request.	chipx86	July 29, 2022, 2:04 p.m.
Missing , unused.	maubin	July 29, 2022, 2:06 p.m.
The function can take local_site_name=None.	chipx86	July 29, 2022, 2:06 p.m.
Add a Version Added:	maubin	July 29, 2022, 2:07 p.m.
Add a Version Added:	maubin	July 29, 2022, 2:07 p.m.
Missing , unused? Same for the other setup_ and check_ methods.	maubin	July 29, 2022, 2:07 p.m.
Missing a period at the end.	maubin	July 29, 2022, 2:08 p.m.
Add a Version Added:	maubin	July 29, 2022, 2:09 p.m.
Add a Version Added:	maubin	July 29, 2022, 2:09 p.m.
Missing a period at the end.	maubin	July 29, 2022, 2:09 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	July 29, 2022, 2:11 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/repository_group.py (Diff revision 1)

Show all issues

'djblets.util.decorators.augment_method_from' imported but unused

Column: 1
Error code: F401

reviewboard/webapi/resources/repository_group.py (Diff revision 1)

Show all issues

'reviewboard.scmtools.models.Repository' imported but unused

Column: 1
Error code: F401

reviewboard/webapi/resources/repository_group.py (Diff revision 1)

Show all issues

local variable 'local_site' is assigned to but never used

Column: 9
Error code: F841

reviewboard/webapi/resources/repository_user.py (Diff revision 1)

Show all issues

'reviewboard.scmtools.models.Repository' imported but unused

Column: 1
Error code: F401

reviewboard/webapi/resources/repository_user.py (Diff revision 1)

Show all issues

local variable 'local_site' is assigned to but never used

Column: 9
Error code: F841

reviewboard/webapi/tests/test_repository_group.py (Diff revision 1)
Show all issues
```
too many blank lines (3)

Column: 1
Error code: E303
```

reviewboard/webapi/tests/test_repository_user.py (Diff revision 1)

Show all issues

local variable 'user' is assigned to but never used

Column: 9
Error code: F841

reviewboard/webapi/tests/urls.py (Diff revision 1)

Show all issues

expected 2 blank lines, found 1

Column: 1
Error code: E302

reviewboard/webapi/tests/urls.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

Commits:

	Summary	ID
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	7db29c4ca8c6a6b1160542d5480246e324d30df9
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	40afbdd711a8eb5b7aaec8117c63f87152cbacb9

Diff:

Revision 2 (+2954)

Show changes

	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/resources/repository_group.py
	reviewboard/webapi/resources/repository_user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_repository_group.py
	reviewboard/webapi/tests/test_repository_user.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
This will have to be 4.0.11 now. Sorry :/
Same in other places.
```
reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
These should be swapped.
```
reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
Missing , optional.
```
reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
For future-proofing, let's pass in request as a keyword argument.
```
reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
We could just pass local_site_name as a keyword argument.
```
reviewboard/webapi/resources/repository_user.py (Diff revision 2)
Show all issues
```
These should be swapped.
```
reviewboard/webapi/resources/repository_user.py (Diff revision 2)
Show all issues
```
Missing , optional.
```
reviewboard/webapi/resources/repository_user.py (Diff revision 2)
Show all issues
```
Same as above, let's do request=request.
```
reviewboard/webapi/resources/repository_user.py (Diff revision 2)
Show all issues
```
The function can take local_site_name=None.
```

reviewboard/webapi/resources/repository_group.py (Diff revision 2)
Show all issues
```
Missing , unused
```

reviewboard/webapi/resources/repository_group.py (Diff revision 2)

Show all issues

Why not use repository.is_accessible_by here? Same with the other has_access_permissions and has_list_access_permissions methods.

david July 29, 2022, 2:03 p.m.

This is an admin-only resource, so we really only want it accessible if it's also mutable.

reviewboard/webapi/resources/repository_user.py (Diff revision 2)
Show all issues
```
Missing , unused.
```
reviewboard/webapi/tests/test_repository_group.py (Diff revision 2)
Show all issues
```
Add a Version Added:
```
reviewboard/webapi/tests/test_repository_group.py (Diff revision 2)
Show all issues
```
Add a Version Added:
```
reviewboard/webapi/tests/test_repository_group.py (Diff revision 2)
Show all issues
```
Missing , unused? Same for the other setup_ and check_ methods.
```
reviewboard/webapi/tests/test_repository_group.py (Diff revision 2)
Show all issues
```
Missing a period at the end.
```
reviewboard/webapi/tests/test_repository_user.py (Diff revision 2)
Show all issues
```
Add a Version Added:
```
reviewboard/webapi/tests/test_repository_user.py (Diff revision 2)
Show all issues
```
Add a Version Added:
```
reviewboard/webapi/tests/test_repository_user.py (Diff revision 2)
Show all issues
```
Missing a period at the end.
```

Commits:

	Summary	ID
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	40afbdd711a8eb5b7aaec8117c63f87152cbacb9
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	2089ec16a34ad2a58294339173428e554269c36e

Diff:

Revision 3 (+2986)

Show changes

	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/resources/repository_group.py
	reviewboard/webapi/resources/repository_user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_repository_group.py
	reviewboard/webapi/tests/test_repository_user.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/repository_group.py (Diff revision 3)
Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	2089ec16a34ad2a58294339173428e554269c36e
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	6fbe71286e709ee3851b6667d227d79d0ce859ad

Diff:

Revision 4 (+2988)

Show changes

	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/resources/repository_group.py
	reviewboard/webapi/resources/repository_user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_repository_group.py
	reviewboard/webapi/tests/test_repository_user.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Commits:

	Summary	ID	Author
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	6fbe71286e709ee3851b6667d227d79d0ce859ad	David Trowbridge
	Add a management command for invalidating tokens This change adds an `rb-site manage /path/to/site invalidate-api-tokens` command that allows administrators to invalidate the API tokens for a set of users. Now tokens can be invalidated individually via the API, or in batch with this command. Testing Done: Manually tested the command and checked that the right tokens were being invalidated. Reviewed at https://reviews.reviewboard.org/r/12481/	913976c93b0a7d6f3415981d5e9ccee7c1a85fd4	Michelle Aubin

Branch:

-	release-4.0.x
+	release-5.0.x

Diff:

Revision 5 (+298 -8)

Show changes

	docs/manual/admin/sites/management-commands.rst
	reviewboard/accounts/sso/backends/saml/views.py
	reviewboard/accounts/tests/test_saml_views.py
	reviewboard/webapi/management/__init__.py
	reviewboard/webapi/management/commands/__init__.py
	reviewboard/webapi/management/commands/invalidate-api-tokens.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Posted wrong change to wrong review request.

Commits:

	Summary	ID	Author
	Add a management command for invalidating tokens This change adds an `rb-site manage /path/to/site invalidate-api-tokens` command that allows administrators to invalidate the API tokens for a set of users. Now tokens can be invalidated individually via the API, or in batch with this command. Testing Done: Manually tested the command and checked that the right tokens were being invalidated. Reviewed at https://reviews.reviewboard.org/r/12481/	913976c93b0a7d6f3415981d5e9ccee7c1a85fd4	Michelle Aubin
	Add new API endpoints for managing repository ACLs. One thing we've had requests for over the years is a way to manage repository ACLs via scripts or other automation. This change adds two new API endpoints for these. These are both children of the repository resource, and work similarly to the existing group member resource. Testing Done: - Ran unit tests. - Made a variety of API requests to manage repository ACLs.	6fbe71286e709ee3851b6667d227d79d0ce859ad	David Trowbridge

Branch:

-	release-5.0.x
+	release-4.0.x

Diff:

Revision 6 (+2988)

Show changes

	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/resources/repository_group.py
	reviewboard/webapi/resources/repository_user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_repository_group.py
	reviewboard/webapi/tests/test_repository_user.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (fb4e2d1)