Add new API endpoints for managing repository ACLs.
Review Request #12489 — Created July 27, 2022 and submitted
One thing we've had requests for over the years is a way to manage
repository ACLs via scripts or other automation. This change adds two
new API endpoints for these. These are both children of the repository
resource, and work similarly to the existing group member resource.
- Ran unit tests.
- Made a variety of API requests to manage repository ACLs.
Summary | ID |
---|---|
6fbe71286e709ee3851b6667d227d79d0ce859ad |
Description | From | Last Updated |
---|---|---|
'djblets.util.decorators.augment_method_from' imported but unused Column: 1 Error code: F401 |
reviewbot | |
'reviewboard.scmtools.models.Repository' imported but unused Column: 1 Error code: F401 |
reviewbot | |
local variable 'local_site' is assigned to but never used Column: 9 Error code: F841 |
reviewbot | |
'reviewboard.scmtools.models.Repository' imported but unused Column: 1 Error code: F401 |
reviewbot | |
local variable 'local_site' is assigned to but never used Column: 9 Error code: F841 |
reviewbot | |
too many blank lines (3) Column: 1 Error code: E303 |
reviewbot | |
local variable 'user' is assigned to but never used Column: 9 Error code: F841 |
reviewbot | |
expected 2 blank lines, found 1 Column: 1 Error code: E302 |
reviewbot | |
line too long (80 > 79 characters) Column: 80 Error code: E501 |
reviewbot | |
This will have to be 4.0.11 now. Sorry :/ Same in other places. |
chipx86 | |
These should be swapped. |
chipx86 | |
Missing , optional. |
chipx86 | |
For future-proofing, let's pass in request as a keyword argument. |
chipx86 | |
Missing , unused |
maubin | |
Why not use repository.is_accessible_by here? Same with the other has_access_permissions and has_list_access_permissions methods. |
maubin | |
We could just pass local_site_name as a keyword argument. |
chipx86 | |
These should be swapped. |
chipx86 | |
Missing , optional. |
chipx86 | |
Same as above, let's do request=request. |
chipx86 | |
Missing , unused. |
maubin | |
The function can take local_site_name=None. |
chipx86 | |
Add a Version Added: |
maubin | |
Add a Version Added: |
maubin | |
Missing , unused? Same for the other setup_ and check_ methods. |
maubin | |
Missing a period at the end. |
maubin | |
Add a Version Added: |
maubin | |
Add a Version Added: |
maubin | |
Missing a period at the end. |
maubin | |
line too long (81 > 79 characters) Column: 80 Error code: E501 |
reviewbot |
- Commits:
-
Summary ID 7db29c4ca8c6a6b1160542d5480246e324d30df9 40afbdd711a8eb5b7aaec8117c63f87152cbacb9 - Diff:
-
Revision 2 (+2954)
Checks run (2 succeeded)
- Commits:
-
Summary ID 40afbdd711a8eb5b7aaec8117c63f87152cbacb9 2089ec16a34ad2a58294339173428e554269c36e - Diff:
-
Revision 3 (+2986)
- Commits:
-
Summary ID 2089ec16a34ad2a58294339173428e554269c36e 6fbe71286e709ee3851b6667d227d79d0ce859ad - Diff:
-
Revision 4 (+2988)
Checks run (2 succeeded)
- Commits:
-
Summary ID Author 6fbe71286e709ee3851b6667d227d79d0ce859ad David Trowbridge 913976c93b0a7d6f3415981d5e9ccee7c1a85fd4 Michelle Aubin - Branch:
-
release-4.0.xrelease-5.0.x
- Diff:
-
Revision 5 (+298 -8)
Checks run (2 succeeded)
- Change Summary:
-
Posted wrong change to wrong review request.
- Commits:
-
Summary ID Author 913976c93b0a7d6f3415981d5e9ccee7c1a85fd4 Michelle Aubin 6fbe71286e709ee3851b6667d227d79d0ce859ad David Trowbridge - Branch:
-
release-5.0.xrelease-4.0.x
- Diff:
-
Revision 6 (+2988)