Summary

Switch to pytest as the test runner.

Review Request #12487 — Created July 25, 2022 and submitted July 26, 2022, 6:33 p.m.

Information

Owner

chipx86

Repository

beanbag-docutils

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

This updates the codebase to use pytest instead of nose for running
unit tests. This helps us with testing on newer versions of Python, and
is consistent with our other codebases.

The old tests/runtests.py script will now wrap pytest.

Testing Done

Ran unit tests on all supported versions of Python.

Commits

Summary	ID
Switch to pytest as the test runner. This updates the codebase to use `pytest` instead of `nose` for running unit tests. This helps us with testing on newer versions of Python, and is consistent with our other codebases. The old `tests/runtests.py` script will now wrap `pytest`.	99b9714e12ac1ebc9982a9f0e4e38bf385526220

Issues

Description	From	Last Updated
Do we not want to have a runtests.py file that just invokes pytest?	david	July 25, 2022, 11:48 p.m.
It looks like tests/runtests.py is still deleted? There's no difference between diffs 1 and 2.	maubin	July 26, 2022, 5:59 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Do we not want to have a runtests.py file that just invokes pytest?

Change Summary:

Restored runtests.py, having it wrap pytest.

Description:

		This updates the codebase to use `pytest` instead of `nose` for running
		unit tests. This helps us with testing on newer versions of Python, and
		is consistent with our other codebases.
	+
	+	The old `tests/runtests.py` script will now wrap `pytest`.

Commits:

	Summary	ID
	Switch to pytest as the test runner. This updates the codebase to use `pytest` instead of `nose` for running unit tests. This helps us with testing on newer versions of Python, and is consistent with our other codebases.	bf17f12857eb8ecf1a548a9636a084536a925cc4
	Switch to pytest as the test runner. This updates the codebase to use `pytest` instead of `nose` for running unit tests. This helps us with testing on newer versions of Python, and is consistent with our other codebases. The old `tests/runtests.py` script will now wrap `pytest`.	309d4af8135b8a9cd57c83287e109d6f24d3d832

Diff:

Revision 2 (+16 -56)

Show changes

	dev-requirements.txt
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

It looks like tests/runtests.py is still deleted? There's no difference between diffs 1 and 2.

chipx86 July 26, 2022, 5:59 p.m.
```
Yyyyep. Oops. Fixing.
```

Change Summary:

Actually added back runtests.py.

Commits:

	Summary	ID
	Switch to pytest as the test runner. This updates the codebase to use `pytest` instead of `nose` for running unit tests. This helps us with testing on newer versions of Python, and is consistent with our other codebases. The old `tests/runtests.py` script will now wrap `pytest`.	309d4af8135b8a9cd57c83287e109d6f24d3d832
	Switch to pytest as the test runner. This updates the codebase to use `pytest` instead of `nose` for running unit tests. This helps us with testing on newer versions of Python, and is consistent with our other codebases. The old `tests/runtests.py` script will now wrap `pytest`.	99b9714e12ac1ebc9982a9f0e4e38bf385526220

Diff:

Revision 3 (+22 -44)

Show changes

	dev-requirements.txt
	tests/runtests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (7927ed8)