Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

 






 

 


  Review Request #12475
  —
  Created July 17, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
We made some changes inside Review Board to upgrade the CACHES setting

during upgrade, but that neglected to handle the case where the cache

was set in siteconfig. We already had some migration logic for previous

renames, so I've just extended that to also include this new rename.

 








  


 
 

  
    

  • Set up a reproduction case where we had outdated CACHES configuration
    
  in siteconfig. Saw that I could run everything and that the
    
  configuration that got applied to django.conf.settings used
    
PyMemcacheCache. Verified that the configuration UI inside Review
    
  Board's admin showed the correct setting as well (was previously
    
  showing as "custom" when un-migrated).
    • 

  • Ran unit tests.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
     
We made some changes inside Review Board to upgrade the CACHES setting
during upgrade, but that neglected to handle the case where the cache
was set in siteconfig. We already had some migration logic for previous
renames, so I've just extended

Testing Done:
- Set up a reproduction case where we had outdated CACHES configuration
  in siteconfig. Saw that I could run everything and that the
  configuration that got applied to `django.conf.settings` used
  `PyMemcacheCache`. Verified that the configuration UI inside Review
  Board's admin showed the correct setting as well (was previously
  showing as "custom" when un-migrated).
- Ran unit tests.

    

   
  		
  8c6bd627fddbdf5f9fba04da966813221e067d15
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/cache/backend_compat.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/siteconfig/tests.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...