Summary:

Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

Review Request #12475 — Created July 17, 2022 and submitted July 18, 2022, 5:47 p.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-3.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

We made some changes inside Review Board to upgrade the CACHES setting
during upgrade, but that neglected to handle the case where the cache
was set in siteconfig. We already had some migration logic for previous
renames, so I've just extended that to also include this new rename.

Testing Done


Set up a reproduction case where we had outdated CACHES configuration

  in siteconfig. Saw that I could run everything and that the

  configuration that got applied to django.conf.settings used

PyMemcacheCache. Verified that the configuration UI inside Review

  Board's admin showed the correct setting as well (was previously

  showing as "custom" when un-migrated).
Ran unit tests.

Commits

Summary
	Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

Screenshots

Issues

Description	From	Last Updated
After fixing the other issues, should be good to go.	maubin	July 18, 2022, 1:47 p.m.
Can you also update the release notes? (I'm going to have to re-release the beta — it's not announced, but …	chipx86	July 18, 2022, 1:48 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	July 18, 2022, 1:49 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	July 18, 2022, 1:49 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	July 18, 2022, 1:49 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	July 18, 2022, 1:49 p.m.
continuation line unaligned for hanging indent Column: 22 Error code: E131	reviewbot	July 18, 2022, 1:49 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/siteconfig/tests.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

djblets/siteconfig/tests.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

djblets/siteconfig/tests.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

djblets/siteconfig/tests.py (Diff revision 1)

Show all issues

line too long (80 > 79 characters)

Column: 80
Error code: E501

Show all issues

Can you also update the release notes? (I'm going to have to re-release the beta — it's not announced, but release notes are live.)

Ship it!

Show all issues

After fixing the other issues, should be good to go.

Commits:

	Summary
-		Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
+		Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

Diff:

Revision 2 (+108 -16)

Show changes

	djblets/cache/backend_compat.py
	djblets/siteconfig/tests.py
	docs/releasenotes/3.0-beta-1.rst

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/siteconfig/tests.py (Diff revision 2)

Show all issues

continuation line unaligned for hanging indent

Column: 22
Error code: E131

Commits:

	Summary
-		Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
+		Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

Diff:

Revision 3 (+108 -16)

Show changes

	djblets/cache/backend_compat.py
	djblets/siteconfig/tests.py
	docs/releasenotes/3.0-beta-1.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (8d2c0f3)