Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.

Review Request #12475 — Created July 17, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

We made some changes inside Review Board to upgrade the CACHES setting
during upgrade, but that neglected to handle the case where the cache
was set in siteconfig. We already had some migration logic for previous
renames, so I've just extended that to also include this new rename.

  • Set up a reproduction case where we had outdated CACHES configuration
    in siteconfig. Saw that I could run everything and that the
    configuration that got applied to django.conf.settings used
    PyMemcacheCache. Verified that the configuration UI inside Review
    Board's admin showed the correct setting as well (was previously
    showing as "custom" when un-migrated).
  • Ran unit tests.
Summary ID
Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
We made some changes inside Review Board to upgrade the CACHES setting during upgrade, but that neglected to handle the case where the cache was set in siteconfig. We already had some migration logic for previous renames, so I've just extended that to also include this new rename. Testing Done: - Set up a reproduction case where we had outdated CACHES configuration in siteconfig. Saw that I could run everything and that the configuration that got applied to `django.conf.settings` used `PyMemcacheCache`. Verified that the configuration UI inside Review Board's admin showed the correct setting as well (was previously showing as "custom" when un-migrated). - Ran unit tests.
52a118ec23169a8b9730e4d848b7374a190f7c76
Description From Last Updated

After fixing the other issues, should be good to go.

maubinmaubin

Can you also update the release notes? (I'm going to have to re-release the beta — it's not announced, but …

chipx86chipx86

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

continuation line unaligned for hanging indent Column: 22 Error code: E131

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
  1. 
      
  2. Can you also update the release notes? (I'm going to have to re-release the beta — it's not announced, but release notes are live.)

  3. 
      
maubin
  1. 
      
  2. After fixing the other issues, should be good to go.

  3. 
      
david
Review request changed

Commits:

Summary ID
Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
We made some changes inside Review Board to upgrade the CACHES setting during upgrade, but that neglected to handle the case where the cache was set in siteconfig. We already had some migration logic for previous renames, so I've just extended Testing Done: - Set up a reproduction case where we had outdated CACHES configuration in siteconfig. Saw that I could run everything and that the configuration that got applied to `django.conf.settings` used `PyMemcacheCache`. Verified that the configuration UI inside Review Board's admin showed the correct setting as well (was previously showing as "custom" when un-migrated). - Ran unit tests.
8c6bd627fddbdf5f9fba04da966813221e067d15
Handle MemcachedCache -> PyMemcacheCache in apply_django_settings.
We made some changes inside Review Board to upgrade the CACHES setting during upgrade, but that neglected to handle the case where the cache was set in siteconfig. We already had some migration logic for previous renames, so I've just extended that to also include this new rename. Testing Done: - Set up a reproduction case where we had outdated CACHES configuration in siteconfig. Saw that I could run everything and that the configuration that got applied to `django.conf.settings` used `PyMemcacheCache`. Verified that the configuration UI inside Review Board's admin showed the correct setting as well (was previously showing as "custom" when un-migrated). - Ran unit tests.
5ab5c728e419107f60c5d9490864796db4abcbd5

Diff:

Revision 2 (+108 -16)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (8d2c0f3)
Loading...