• 
      

    Fix CACHES migration.

    Review Request #12458 — Created July 11, 2022 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    When I implemented the migration code to update the CACHES setting from
    the old MemcachedCache to the new PymemcacheCache, I tested the
    actual migration implementation, but had just made an assumption about
    the code that checks if we need to run it. It turns out this had two
    problems--we were skipping one step that needed to check if a settings
    update was required, and in the running context of rb-site, the key that
    we need to check is forwarded_backend instead of default.

    Ran a real rb-site upgrade and saw that my settings_local.py file was
    correctly updated.

    Summary ID
    Fix CACHES migration.
    When I implemented the migration code to update the CACHES setting from the old `MemcachedCache` to the new `PymemcacheCache`, I tested the actual migration implementation, but had just made an assumption about the code that checks if we need to run it. It turns out this had two problems--we were skipping one step that needed to check if a settings update was required, and in the running context of rb-site, the key that we need to check is `forwarded_backend` instead of `default`. Testing Done: Ran a real `rb-site upgrade` and saw that my settings_local.py file was correctly updated.
    7dc09ae91a48be2f5a148591a6c411ff0506645a
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.0.x (fb2be9a)