Summary

Allow Djblets to patch collections when running rbext.

Review Request #12449 — Created July 10, 2022 and submitted July 10, 2022, 10:17 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Most of our command line tools were updated to allow Djblets to patch

the collections module on Python 3.10, but rbext was not. This meant

that if you're using Python 3.10, you're unable to invoke rbext at all

on Python 3.10. Whether this has been hit in the wild is unknown, but

it's blocking a new CI pipeline.
We now import djblets early in the module, giving Djblets the

opportunity to apply the patch.

Testing Done

Successfully ran rbext using Python 3.10.

Commits

Summary	ID
Allow Djblets to patch collections when running rbext. Most of our command line tools were updated to allow Djblets to patch the `collections` module on Python 3.10, but `rbext` was not. This meant that if you're using Python 3.10, you're unable to invoke `rbext` at all on Python 3.10. Whether this has been hit in the wild is unknown, but it's blocking a new CI pipeline. We now `import djblets` early in the module, giving Djblets the opportunity to apply the patch.	816ac529c5134625977f2c0c6e5cc32a007d1cdd

Summary

Allow Djblets to patch collections when running rbext.

Most of our command line tools were updated to allow Djblets to patch the `collections` module on Python 3.10, but `rbext` was not. This meant that if you're using Python 3.10, you're unable to invoke `rbext` at all on Python 3.10. Whether this has been hit in the wild is unknown, but it's blocking a new CI pipeline. We now `import djblets` early in the module, giving Djblets the opportunity to apply the patch.

816ac529c5134625977f2c0c6e5cc32a007d1cdd

Issues

Description	From	Last Updated
'djblets' imported but unused Column: 1 Error code: F401	reviewbot	July 10, 2022, 10:16 p.m.
module level import not at top of file Column: 1 Error code: E402	reviewbot	July 10, 2022, 10:16 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'djblets' imported but unused

Column: 1
Error code: F401
```
reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
module level import not at top of file

Column: 1
Error code: E402
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (5f29736)