Summary

Make testing for root reviews and root comments APIs more robust and clear

Review Request #12445 — Created July 8, 2022 and submitted July 29, 2022, 10:39 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change improves the tests for the root reviews and root comments
API endpoints. The tests are more clear, organized and well documented,
and have more comprehensive test coverage surrounding access control.

Testing Done

Successfully ran the unit tests that were modified.

Commits

Summary	ID
Make testing for root reviews and root comments API more robust and clear	8d195ffb5a017277d16614d4eafa1a88dcd8dd16

Issues

Description	From	Last Updated
This extra blank line can go away.	david	July 20, 2022, 10:59 a.m.
No blank line here.	chipx86	July 29, 2022, 9:43 a.m.
No blank line here.	chipx86	July 29, 2022, 9:43 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
This is great!
```
reviewboard/webapi/tests/test_root_diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This extra blank line can go away.
```

Change Summary:

Removed blank line between first line and doc strings in some methods.

Commits:

	Summary	ID
	Make testing for root reviews and root comments API more robust and clear	de7cb9c4c6d477232903e16cd7bde17e550d7c79
	Make testing for root reviews and root comments API more robust and clear	030b25e29cc2f77d13aafc09ccb814acac288e0b

Diff:

Revision 2 (+3016 -1710)

Show changes

	reviewboard/webapi/tests/test_root_diff_comment.py
	reviewboard/webapi/tests/test_root_file_attachment_comment.py
	reviewboard/webapi/tests/test_root_general_comment.py
	reviewboard/webapi/tests/test_root_review.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

This is a lot of work, and it's excellent. Thanks for doing this!

Two tiny nits, then ship it :)

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```

Summary:

-	Make testing for root reviews and root comments API more robust and clear
+	Make testing for root reviews and root comments APIs more robust and clear

Commits:

	Summary	ID
	Make testing for root reviews and root comments API more robust and clear	030b25e29cc2f77d13aafc09ccb814acac288e0b
	Make testing for root reviews and root comments API more robust and clear	8d195ffb5a017277d16614d4eafa1a88dcd8dd16

Diff:

Revision 3 (+3008 -1710)

Show changes

	reviewboard/webapi/tests/test_root_diff_comment.py
	reviewboard/webapi/tests/test_root_file_attachment_comment.py
	reviewboard/webapi/tests/test_root_general_comment.py
	reviewboard/webapi/tests/test_root_review.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (3d6e1c3)