Summary

Update Review Bot for new Review Board / Django.

Review Request #12442 — Created July 7, 2022 and submitted July 11, 2022, 4:46 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This change makes two small updates to the Review Bot extension when

running against Review Board 5.0. First, the integration has been

updated to use the non-deprecated import path for the Integration class.

Second, the tool options widget's render method needed to be updated

to take the renderer argument.

Testing Done

Activated and configured the review bot extension. Verified that the
integration form worked correctly.

Commits

Summary	ID
Update Review Bot for new Review Board / Django. This change makes two small updates to the Review Bot extension when running against Review Board 5.0. First, the integration has been updated to use the non-deprecated import path for the Integration class. Second, the tool options widget's `render` method needed to be updated to take the renderer argument. Testing Done: Activated and configured the review bot extension. Verified that the integration form worked correctly. Reviewed at https://reviews.reviewboard.org/r/12442/	0f8cd2e164f266966d153c77624847db8361464f

Summary

Update Review Bot for new Review Board / Django.

This change makes two small updates to the Review Bot extension when running against Review Board 5.0. First, the integration has been updated to use the non-deprecated import path for the Integration class. Second, the tool options widget's `render` method needed to be updated to take the renderer argument. Testing Done: Activated and configured the review bot extension. Verified that the integration form worked correctly. Reviewed at https://reviews.reviewboard.org/r/12442/

0f8cd2e164f266966d153c77624847db8361464f

Issues

Description	From	Last Updated
This will break on older versions of Review Board/Django. We should probably take in **kwargs and pass that instead.	chipx86	July 10, 2022, 5:09 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

extension/reviewbotext/widgets.py (Diff revision 1)

The issue has been resolved. Show all issues

This will break on older versions of Review Board/Django.

We should probably take in **kwargs and pass that instead.

Commits:

	Summary	ID
	Update Review Bot for new Review Board / Django. This change makes two small updates to the Review Bot extension when running against Review Board 5.0. First, the integration has been updated to use the non-deprecated import path for the Integration class. Second, the tool options widget's `render` method needed to be updated to take the renderer argument. Testing Done: Activated and configured the review bot extension. Verified that the integration form worked correctly.	6d35eb5b2f556cd2bb1a1ba5ec14ed0ceb8b21c0
	Update Review Bot for new Review Board / Django. This change makes two small updates to the Review Bot extension when running against Review Board 5.0. First, the integration has been updated to use the non-deprecated import path for the Integration class. Second, the tool options widget's `render` method needed to be updated to take the renderer argument. Testing Done: Activated and configured the review bot extension. Verified that the integration form worked correctly. Reviewed at https://reviews.reviewboard.org/r/12442/	0f8cd2e164f266966d153c77624847db8361464f

Diff:

Revision 2 (+20 -6)

Show changes

	extension/reviewbotext/integration.py
	extension/reviewbotext/widgets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (0f8cd2e)