Move gravatars tests out of the templatetags module.

 






 

 


  Review Request #12434
  —
  Created July 4, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
The unit tests for the gravatar template tags were living in

djblets.gravatars.templatetags.tests, which was getting loaded when

Django loaded the list of available template tags.


This in turn caused all test-related code to load, including kgb. This

resulted in failures in production.


These tests have now been moved into djblets.gravatars.tests.

 








  


 
 

  
Unit tests pass.


Deployed to production and didn't hit the import issues.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Move gravatars tests out of the templatetags module.
     
The unit tests for the gravatar template tags were living in
`djblets.gravatars.templatetags.tests`, which was getting loaded when
Django loaded the list of available template tags.

This in turn caused all test-related code to load, including `kgb`. This
resulted in failures in production.

These tests have now been moved into `djblets.gravatars.tests`.

    

   
  		
  17920aab21a54eb982d9e9b494026f2b33ade82a
  Christian Hammond
 


 
  
 
 
  
   
    

     Move gravatars tests out of the templatetags module.
     
The unit tests for the gravatar template tags were living in
`djblets.gravatars.templatetags.tests`, which was getting loaded when
Django loaded the list of available template tags.

This in turn caused all test-related code to load, including `kgb`. This
resulted in failures in production.

These tests have now been moved into `djblets.gravatars.tests`.

    

   
  		
  4b1f8fd789c5b98d70150b863580e9cf018e993c
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/gravatars/tests.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...