Summary

Move gravatars tests out of the templatetags module.

Review Request #12434 — Created July 4, 2022 and submitted July 6, 2022, 2:26 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The unit tests for the gravatar template tags were living in
djblets.gravatars.templatetags.tests, which was getting loaded when
Django loaded the list of available template tags.

This in turn caused all test-related code to load, including kgb. This
resulted in failures in production.

These tests have now been moved into djblets.gravatars.tests.

Testing Done

Unit tests pass.
Deployed to production and didn't hit the import issues.

Commits

Summary	ID
Move gravatars tests out of the templatetags module. The unit tests for the gravatar template tags were living in `djblets.gravatars.templatetags.tests`, which was getting loaded when Django loaded the list of available template tags. This in turn caused all test-related code to load, including `kgb`. This resulted in failures in production. These tests have now been moved into `djblets.gravatars.tests`.	4b1f8fd789c5b98d70150b863580e9cf018e993c

Summary

Move gravatars tests out of the templatetags module.

The unit tests for the gravatar template tags were living in `djblets.gravatars.templatetags.tests`, which was getting loaded when Django loaded the list of available template tags. This in turn caused all test-related code to load, including `kgb`. This resulted in failures in production. These tests have now been moved into `djblets.gravatars.tests`.

4b1f8fd789c5b98d70150b863580e9cf018e993c

Issues

Description	From	Last Updated
Need a blank line in here.	david	July 6, 2022, 1:53 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

djblets/gravatars/tests.py (Diff revision 1)
Show all issues
```
Need a blank line in here.
```

Change Summary:

Added a missing blank line.

Commits:

	Summary	ID
	Move gravatars tests out of the templatetags module. The unit tests for the gravatar template tags were living in `djblets.gravatars.templatetags.tests`, which was getting loaded when Django loaded the list of available template tags. This in turn caused all test-related code to load, including `kgb`. This resulted in failures in production. These tests have now been moved into `djblets.gravatars.tests`.	17920aab21a54eb982d9e9b494026f2b33ade82a
	Move gravatars tests out of the templatetags module. The unit tests for the gravatar template tags were living in `djblets.gravatars.templatetags.tests`, which was getting loaded when Django loaded the list of available template tags. This in turn caused all test-related code to load, including `kgb`. This resulted in failures in production. These tests have now been moved into `djblets.gravatars.tests`.	4b1f8fd789c5b98d70150b863580e9cf018e993c

Diff:

Revision 2 (+68 -72)

Show changes

	djblets/gravatars/tests.py
	djblets/gravatars/templatetags/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (8818cff)

djblets/gravatars/tests.py (Diff revision 1)