Remove last deprecations scheduled for 5.0

Review Request #12429 — Created June 30, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

This change removes the last bit of deprecated API for 5.0: the old
get_orig_commit_id method. This was more complex than the rest because
the mercurial backend still used it in its diff parsers (both mercurial
and git modes).

I've updated the hg parsers to instead set the parent commit ID on the
parsed diff change, as well as set the uses_commit_ids_as_revisions
flag.

This also required updating a unit test which wasn't set up quite right.
Now that commits and parent commits are done per file instead of per
diff (as per all the other machinery in create_filediffs), we can't
have a parent diff that specifies different files than the diff and
expect the parent diff commit ID to get set correctly.

Testing Done:

Ran unit tests.

Summary ID
Remove last deprecations scheduled for 5.0
This change removes the last bit of deprecated API for 5.0: the old get_orig_commit_id method. This was more complex than the rest because the mercurial backend still used it in its diff parsers (both mercurial and git modes). I've updated the hg parsers to instead set the parent commit ID on the parsed diff change, as well as set the ``uses_commit_ids_as_revisions`` flag. This also required updating a unit test which wasn't set up quite right. Now that commits and parent commits are done per file instead of per diff (as per all the other machinery in `create_filediffs`), we can't have a parent diff that specifies different files than the diff and expect the parent diff commit ID to get set correctly. Testing Done: Ran unit tests.
dd524ba74ff19d2e4e3cccd6b8f1469a0b02823e
Description From Last Updated

"Testing Done:" snuck into the description.

chipx86chipx86

This can be op=kgb.SpyOpReturn(True).

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. "Testing Done:" snuck into the description.

  3. This can be op=kgb.SpyOpReturn(True).

  4. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (39bf937)
Loading...