Always use parens around division in our .less files.

Review Request #12404 — Created June 23, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

LessCSS 4.0 began to require parenthesis around division by default, in
order to force immediate evaluation. This change was made because CSS
now uses / as non-math syntax for a lot of modern rules. LessCSS
previously allowed codebases to opt into a parens-division mode that
played nicer with modern CSS, but with 4.0 they made that mode the
default.

We were already using parens around most of our division, but there were
a couple cases that produced outright errors, and some that likely were
now outputting bad CSS.

This change adds parens around all division remaining in our codebase.

Successfully compiled the CSS.

Went through the UI. Didn't see any obvious breakages, but we'll need
to test more as we move this to production.

Summary ID
Always use parens around division in our .less files.
LessCSS 4.0 began to require parenthesis around division by default, in order to force immediate evaluation. This change was made because CSS now uses `/` as non-math syntax for a lot of modern rules. LessCSS previously allowed codebases to opt into a `parens-division` mode that played nicer with modern CSS, but with 4.0 they made that mode the default. We were already using parens around most of our division, but there were a couple cases that produced outright errors, and some that likely were now outputting bad CSS. This change adds parens around all division remaining in our codebase.
a55056a0e5337c5aac899fbe5714ab7861ba00c8
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (9d35e38)
Loading...