Summary

Make LocalSite filtering in HostingServiceAccountManager conditional.

Review Request #12398 — Created June 22, 2022 and submitted June 23, 2022, 2:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

HostingServiceAccount.objects.accessible() no longer unconditionally
filters by LocalSite. Most deployments don't use Local Site
functionality, making the addition of this filter unnecessarily
expensive in the common case.

This change uses LocalSite.objects.has_local_sites() to determine
whether to include the filter.

It also removes the distinct() call, which is really not necessary for
this query.

Testing Done

Unit tests pass.

Commits

Summary	ID
Make LocalSite filtering in HostingServiceAccountManager conditional. `HostingServiceAccount.objects.accessible()` no longer unconditionally filters by `LocalSite`. Most deployments don't use Local Site functionality, making the addition of this filter unnecessarily expensive in the common case. This change uses `LocalSite.objects.has_local_sites()` to determine whether to include the filter. It also removes the `distinct()` call, which is really not necessary for this query.	d650e557b6de1853966bca3ca0edc62147171150

Summary

Make LocalSite filtering in HostingServiceAccountManager conditional.

`HostingServiceAccount.objects.accessible()` no longer unconditionally filters by `LocalSite`. Most deployments don't use Local Site functionality, making the addition of this filter unnecessarily expensive in the common case. This change uses `LocalSite.objects.has_local_sites()` to determine whether to include the filter. It also removes the `distinct()` call, which is really not necessary for this query.

d650e557b6de1853966bca3ca0edc62147171150

Issues

Description	From	Last Updated
'djblets.testing.decorators.add_fixtures' imported but unused Column: 1 Error code: F401	reviewbot	June 22, 2022, 3:50 p.m.
local variable 'account2' is assigned to but never used Column: 9 Error code: F841	reviewbot	June 22, 2022, 3:50 p.m.
local variable 'account3' is assigned to but never used Column: 9 Error code: F841	reviewbot	June 22, 2022, 3:51 p.m.
local variable 'account4' is assigned to but never used Column: 9 Error code: F841	reviewbot	June 22, 2022, 3:51 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'djblets.testing.decorators.add_fixtures' imported but unused

Column: 1
Error code: F401
```
reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'account2' is assigned to but never used

Column: 9
Error code: F841
```
reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'account3' is assigned to but never used

Column: 9
Error code: F841
```
reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'account4' is assigned to but never used

Column: 9
Error code: F841
```

Change Summary:

Removed unused imports and variables.

Commits:

	Summary	ID
	Make LocalSite filtering in HostingServiceAccountManager conditional. `HostingServiceAccount.objects.accessible()` no longer unconditionally filters by `LocalSite`. Most deployments don't use Local Site functionality, making the addition of this filter unnecessarily expensive in the common case. This change uses `LocalSite.objects.has_local_sites()` to determine whether to include the filter. It also removes the `distinct()` call, which is really not necessary for this query.	414652ac5767a8f2b2a1dcbe2a62700e726a1d16
	Make LocalSite filtering in HostingServiceAccountManager conditional. `HostingServiceAccount.objects.accessible()` no longer unconditionally filters by `LocalSite`. Most deployments don't use Local Site functionality, making the addition of this filter unnecessarily expensive in the common case. This change uses `LocalSite.objects.has_local_sites()` to determine whether to include the filter. It also removes the `distinct()` call, which is really not necessary for this query.	d650e557b6de1853966bca3ca0edc62147171150

Diff:

Revision 2 (+436 -10)

Show changes

	reviewboard/hostingsvcs/managers.py
	reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (30bc95d)