Allow timestamp to be set for comment models in test cases
Review Request #12394 — Created June 21, 2022 and submitted
Information | |
---|---|
maubin | |
Review Board | |
release-5.0.x | |
12296 | |
Reviewers | |
reviewboard | |
The create methods for comments in
reviewboard.testing.TestCase
does not
properly set the timestamp when atimestamp
argument is passed. This is
because the timestamp is being overriden when when the comment object is saved.
This change allowsreviewboard.testing.TestCase
to properly set the timestamp
when atimestamp
argument is passed.
Ran all unit tests in
reviewboard.webapi.tests
, which make use of the create
comment methods.
Summary |
---|
-
-
reviewboard/testing/testcase.py (Diff revision 1) Can you add a
Version Added
?I know technically this was available to be passed in
**kwargs
, but clearly that didn't work.Same below.
-
reviewboard/testing/testcase.py (Diff revision 1) Our chaining-based formatting doesn't work super well for things like updates.
For things like this, I generally recommend:
queryset = FileAttachmentComment.objects.filter(...) queryset.update(...)
Helps distinguish the query from the operation, when it has to span lines. Of course, the query can be chained as needed.
Same below.

Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+100 -8) |