Summary:

Allow timestamp to be set for comment models in test cases

Review Request #12394 — Created June 21, 2022 and submitted June 24, 2022, 10:33 a.m.

Information
Owner:	maubin
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Blocks:	12296
Reviewers
Groups:	reviewboard
People:

Description

The create methods for comments in reviewboard.testing.TestCase does not
properly set the timestamp when a timestamp argument is passed. This is
because the timestamp is being overriden when when the comment object is saved.
This change allows reviewboard.testing.TestCase to properly set the timestamp
when a timestamp argument is passed.

Testing Done

Ran all unit tests in reviewboard.webapi.tests, which make use of the create
comment methods.

Commits

Summary
Allow timestamp to be set for comment models in test cases

Screenshots

Issues

Description	From	Last Updated
Can you add a Version Added? I know technically this was available to be passed in **kwargs, but clearly that …	chipx86	June 21, 2022, 2:01 p.m.
Our chaining-based formatting doesn't work super well for things like updates. For things like this, I generally recommend: queryset = …	chipx86	June 21, 2022, 2 p.m.

flake8 passed.

JSHint passed.

reviewboard/testing/testcase.py (Diff revision 1)

Show all issues

Can you add a Version Added?

I know technically this was available to be passed in **kwargs, but clearly that didn't work.

Same below.

reviewboard/testing/testcase.py (Diff revision 1)

Show all issues

Our chaining-based formatting doesn't work super well for things like updates.

For things like this, I generally recommend:

queryset = FileAttachmentComment.objects.filter(...)
queryset.update(...)

Helps distinguish the query from the operation, when it has to span lines. Of course, the query can be chained as needed.

Same below.

Commits:

	Summary
-	Allow timestamp to be set for comment models in test cases
+	Allow timestamp to be set for comment models in test cases

Diff:

Revision 2 (+100 -8)

Show changes

reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (f2ee7e0)