flake8
passed.
JSHint
passed.
Allow timestamp to be set for comment models in test cases
Review Request #12394 — Created June 21, 2022 and submitted
The create methods for comments in
reviewboard.testing.TestCasedoes not
properly set the timestamp when atimestampargument is passed. This is
because the timestamp is being overriden when when the comment object is saved.
This change allowsreviewboard.testing.TestCaseto properly set the timestamp
when atimestampargument is passed.
Ran all unit tests in
reviewboard.webapi.tests, which make use of the create
comment methods.
| Summary | ID |
|---|---|
| 8c3938b660d46ba386be3be8fd4d269686b4f826 |
-
-
Can you add a
Version Added?I know technically this was available to be passed in
**kwargs, but clearly that didn't work.Same below.
-
Our chaining-based formatting doesn't work super well for things like updates.
For things like this, I generally recommend:
queryset = FileAttachmentComment.objects.filter(...) queryset.update(...)Helps distinguish the query from the operation, when it has to span lines. Of course, the query can be chained as needed.
Same below.
- Commits:
-
Summary ID 7cfec64995c2d200b77ac99a7de46f4fc6d878e6 8c3938b660d46ba386be3be8fd4d269686b4f826 - Diff:
-
Revision 2 (+100 -8)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
