• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix rbt patch svn to set results_unicode=False
    
 
    

    



 
    
 
    

  Review Request #12372
  —
  Created June 14, 2022 and discarded  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  rpowell
 
    

    





    
 
 
    
  RBTools
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  4973
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  rbtools
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    After applying an SVN patch, attempting to print the output could result in
    
CRITICAL: a bytes-like object is required, not 'str'
    
as the patch output was of type str.
    

    This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by  dushara
    
 
    

    





  

    
 
 
    
  
    Tested locally with an SVN patch, confirmed the patch could apply successfully.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files