Fix rbt patch svn to set results_unicode=False

Review Request #12372 — Created June 14, 2022 and discarded

Information

RBTools
master

Reviewers

After applying an SVN patch, attempting to print the output could result in
CRITICAL: a bytes-like object is required, not 'str'
as the patch output was of type str.

This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara

Tested locally with an SVN patch, confirmed the patch could apply successfully.

Summary ID Author
Fix rbt patch for SVN expecting bytes output
b5451d01ab1c1336154fc77909faf83cbb258c2d Bob Powell
Description From Last Updated

Thanks for the patch! This looks like a symptom of a problem. patch_output should always be bytes, or problems can …

chipx86chipx86
rpowell
chipx86
  1. 
      
  2. Show all issues

    Thanks for the patch!

    This looks like a symptom of a problem. patch_output should always be bytes, or problems can occur elsewhere. It'll be important to find out why these are becoming str instead.

  3. 
      
rpowell
rpowell
rpowell
david
Review request changed
Status:
Discarded