Fix rbt patch svn to set results_unicode=False

Review Request #12372 — Created June 14, 2022 and updated

rpowell
RBTools
master
4973
rbtools

After applying an SVN patch, attempting to print the output could result in
CRITICAL: a bytes-like object is required, not 'str'
as the patch output was of type str.

This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara

Tested locally with an SVN patch, confirmed the patch could apply successfully.

Summary Author
Fix rbt patch for SVN expecting bytes output
Bob Powell
Description From Last Updated

Thanks for the patch! This looks like a symptom of a problem. patch_output should always be bytes, or problems can …

chipx86chipx86
rpowell
chipx86
  1. 
      
  2. Thanks for the patch!

    This looks like a symptom of a problem. patch_output should always be bytes, or problems can occur elsewhere. It'll be important to find out why these are becoming str instead.

  3. 
      
rpowell
rpowell
rpowell
Review request changed

Summary:

-Fix rbt patch to print string output with stdout instead of stdout_bytes
+Fix rbt patch svn to set results_unicode=False
Loading...