flake8
passed.
JSHint
passed.
Fix rbt patch svn to set results_unicode=False
Review Request #12372 — Created June 14, 2022 and discarded
After applying an SVN patch, attempting to print the output could result in
CRITICAL: a bytes-like object is required, not 'str'
as the patch output was of type str.This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara
Tested locally with an SVN patch, confirmed the patch could apply successfully.
| Summary | ID | Author |
|---|---|---|
| b5451d01ab1c1336154fc77909faf83cbb258c2d | Bob Powell |
| Description | From | Last Updated |
|---|---|---|
|
Thanks for the patch! This looks like a symptom of a problem. patch_output should always be bytes, or problems can … |
 chipx86
|
- Change Summary:
-
update diff with dushara's suggestion on https://hellosplat.com/s/beanbag/tickets/4973/
- Commits:
-
Summary ID Author 528dc1dcb6a8250121c49137e27a28eaeaa3a6fc Bob Powell b5451d01ab1c1336154fc77909faf83cbb258c2d Bob Powell - Diff:
-
Revision 2 (+4 -2)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
After applying an SVN patch, attempting to print the output could result in
CRITICAL: a bytes-like object is required, not 'str' as the patch output was of type str. ~ This change calls the stdout.write function when patch_output is of type str.
~ This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara
