Summary

Fix rbt patch svn to set results_unicode=False

Review Request #12372 — Created June 14, 2022 and discarded Jan. 11, 2024, 12:53 p.m.

Information

Owner

rpowell

Repository

RBTools

Branch

master

Bugs

4973

Depends On

Reviewers

Groups

rbtools

People

Description

After applying an SVN patch, attempting to print the output could result in

CRITICAL: a bytes-like object is required, not 'str'

as the patch output was of type str.
This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by  dushara

Testing Done

Tested locally with an SVN patch, confirmed the patch could apply successfully.

Commits

Summary	ID	Author
Fix rbt patch for SVN expecting bytes output	b5451d01ab1c1336154fc77909faf83cbb258c2d	Bob Powell

Issues

Description	From	Last Updated
Thanks for the patch! This looks like a symptom of a problem. patch_output should always be bytes, or problems can …	chipx86	Aug. 11, 2022, 7:54 p.m.

flake8 passed.

JSHint passed.

Testing Done:: +
Tested locally with an SVN patch, confirmed the patch could apply successfully.

The issue has been resolved. Show all issues

Thanks for the patch!

This looks like a symptom of a problem. patch_output should always be bytes, or problems can occur elsewhere. It'll be important to find out why these are becoming str instead.

Change Summary:

update diff with dushara's suggestion on https://hellosplat.com/s/beanbag/tickets/4973/

Commits:

	Summary	ID	Author
	Fix rbt patch to print string output with stdout instead of stdout_bytes After applying an SVN patch, attempting to print the output could result in CRITICAL: a bytes-like object is required, not 'str' as the patch output was of type str. This change calls the stdout.write function when patch_output is of type str.	528dc1dcb6a8250121c49137e27a28eaeaa3a6fc	Bob Powell
	Fix rbt patch for SVN expecting bytes output	b5451d01ab1c1336154fc77909faf83cbb258c2d	Bob Powell

Diff:

Revision 2 (+4 -2)

Show changes

rbtools/clients/svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:: After applying an SVN patch, attempting to print the output could result in
CRITICAL: a bytes-like object is required, not 'str'
as the patch output was of type str.

~
This change calls the stdout.write function when patch_output is of type str.
~
This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara

Summary:: Fix rbt patch to print string output with stdout instead of stdout_bytes
Fix rbt patch svn to set results_unicode=False

Status:: Discarded

		After applying an SVN patch, attempting to print the output could result in
		CRITICAL: a bytes-like object is required, not 'str'
		as the patch output was of type str.

~		This change calls the stdout.write function when patch_output is of type str.
	~	This change calls the underlying rbtools.utils.process.execute function with the results_unicode=False similar to the git implementation (https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/git.py#L1110) as suggested by dushara