Summary

Add AES encryption/decryption functions for working on iterables.

Review Request #12371 — Created June 14, 2022 and submitted June 16, 2022, 7:06 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This introduces new aes_encrypt_iter() and aes_decrypt_iter()
functions in djblets.secrets.crypto, which can operate on iterables.

aes_encrypt_iter() iterates through an iterable that yields byte or
Unicode strings to encrypt. It then yields the encrypted blocks. It's
smart enough to include the IV in the first block and the finalizer in
the final block.

aes_decrypt_iter() iterates through an iterable of encrypted byte
strings. It yields the decrypted blocks.

These will be used internally for encrypted caching, but can also be
useful for things like streaming data to files or HTTP responses.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add AES encryption/decryption functions for working on iterables. This introduces new `aes_encrypt_iter()` and `aes_decrypt_iter()` functions in `djblets.secrets.crypto`, which can operate on iterables. `aes_encrypt_iter()` iterates through an iterable that yields byte or Unicode strings to encrypt. It then yields the encrypted blocks. It's smart enough to include the IV in the first block and the finalizer in the final block. `aes_decrypt_iter()` iterates through an iterable of encrypted byte strings. It yields the decrypted blocks. These will be used internally for encrypted caching, but can also be useful for things like streaming data to files or HTTP responses.	c79c7adc2e3a1991ef5319f34a879c6ade76dbea

Summary

Add AES encryption/decryption functions for working on iterables.

This introduces new `aes_encrypt_iter()` and `aes_decrypt_iter()` functions in `djblets.secrets.crypto`, which can operate on iterables. `aes_encrypt_iter()` iterates through an iterable that yields byte or Unicode strings to encrypt. It then yields the encrypted blocks. It's smart enough to include the IV in the first block and the finalizer in the final block. `aes_decrypt_iter()` iterates through an iterable of encrypted byte strings. It yields the decrypted blocks. These will be used internally for encrypted caching, but can also be useful for things like streaming data to files or HTTP responses.

c79c7adc2e3a1991ef5319f34a879c6ade76dbea

Issues

Description	From	Last Updated
This should be "decrypted", no?	david	June 16, 2022, 1:58 p.m.
What is "the IV"? We should probably also have consistent capitalization of it.	david	June 16, 2022, 2 p.m.

flake8 passed.

JSHint passed.

djblets/secrets/crypto.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be "decrypted", no?
```

djblets/secrets/crypto.py (Diff revision 1)

The issue has been resolved. Show all issues

What is "the IV"? We should probably also have consistent capitalization of it.

Change Summary:


Fixed a docstring to say "decrypted" instead of "encrypted".
Fixed capitalization of "IV" to be consistent, and defined "IV" in a larger comment.

Commits:

	Summary	ID
	Add AES encryption/decryption functions for working on iterables. This introduces new `aes_encrypt_iter()` and `aes_decrypt_iter()` functions in `djblets.secrets.crypto`, which can operate on iterables. `aes_encrypt_iter()` iterates through an iterable that yields byte or Unicode strings to encrypt. It then yields the encrypted blocks. It's smart enough to include the IV in the first block and the finalizer in the final block. `aes_decrypt_iter()` iterates through an iterable of encrypted byte strings. It yields the decrypted blocks. These will be used internally for encrypted caching, but can also be useful for things like streaming data to files or HTTP responses.	5d854195c022685ef24e121bd0c3d075c061ff98
	Add AES encryption/decryption functions for working on iterables. This introduces new `aes_encrypt_iter()` and `aes_decrypt_iter()` functions in `djblets.secrets.crypto`, which can operate on iterables. `aes_encrypt_iter()` iterates through an iterable that yields byte or Unicode strings to encrypt. It then yields the encrypted blocks. It's smart enough to include the IV in the first block and the finalizer in the final block. `aes_decrypt_iter()` iterates through an iterable of encrypted byte strings. It yields the decrypted blocks. These will be used internally for encrypted caching, but can also be useful for things like streaming data to files or HTTP responses.	c79c7adc2e3a1991ef5319f34a879c6ade76dbea

Diff:

Revision 2 (+740 -8)

Show changes

	djblets/secrets/crypto.py
	djblets/secrets/tests/test_crypto_utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (af4022c)