• 
      

    Fix rbt post with --diff-filename, and improve file not found errors.

    Review Request #12366 — Created June 13, 2022 and submitted

    Information

    RBTools
    release-3.x

    Reviewers

    The support for --diff-filename regressed in RBTools 3.1, due to the
    addition of a new review_request_extra_data attribute on
    SquashedDiff that wasn't being provided (being a namedtuple, all
    arguments always have to be provided). This is now set to the default of
    None.

    Along with this, the error message shown for a File Not Found contained
    the filename but not the revision, making it hard to determine what was
    missing. This is now included.

    Encountered both of these issues while testing another problem. Verified
    that --diff-filename now works, and that the File Not Found error
    contained the correct revision.

    Summary ID
    Fix rbt post with --diff-filename, and improve file not found errors.
    The support for `--diff-filename` regressed in RBTools 3.1, due to the addition of a new `review_request_extra_data` attribute on `SquashedDiff` that wasn't being provided (being a `namedtuple`, all arguments always have to be provided). This is now set to the default of `None`. Along with this, the error message shown for a File Not Found contained the filename but not the revision, making it hard to determine what was missing. This is now included.
    cfb257e68c7ff29be7a1364eb621e64675441ff1
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (c181e55)