Update DataGrid unit tests to use assertQueries().

 






 

 


  Review Request #12364
  —
  Created June 13, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This enhances the datagrid unit tests to use assertQueries() instead

of assertNumQueries(). This gives us greater insight into the queries

being executed when rendering a datagrid, and will help with performance

tuning going forward.


A number of datagrid unit tests lacked any query-related assertions.

This change adds these, and in the process has uncovered some major

performance issues. These will be resolved in upcoming changes.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update DataGrid unit tests to use assertQueries().
     
This enhances the datagrid unit tests to use `assertQueries()` instead
of `assertNumQueries()`. This gives us greater insight into the queries
being executed when rendering a datagrid, and will help with performance
tuning going forward.

A number of datagrid unit tests lacked any query-related assertions.
This change adds these, and in the process has uncovered some major
performance issues. These will be resolved in upcoming changes.

    

   
  		
  1dc60207caf63c24be3ecd1121ba4825fd533e10
  Christian Hammond
 


 
  
 
 
  
   
    

     Update DataGrid unit tests to use assertQueries().
     
This enhances the datagrid unit tests to use `assertQueries()` instead
of `assertNumQueries()`. This gives us greater insight into the queries
being executed when rendering a datagrid, and will help with performance
tuning going forward.

A number of datagrid unit tests lacked any query-related assertions.
This change adds these, and in the process has uncovered some major
performance issues. These will be resolved in upcoming changes.

    

   
  		
  9332521223904bd15af0085858b0c3342500c365
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/tests/test_profile.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/datagrids/tests.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...