Update DataGrid unit tests to use assertQueries().
Review Request #12364 — Created June 12, 2022 and submitted
Information | |
---|---|
chipx86 | |
Review Board | |
release-5.0.x | |
Reviewers | |
reviewboard | |
This enhances the datagrid unit tests to use
assertQueries()
instead
ofassertNumQueries()
. This gives us greater insight into the queries
being executed when rendering a datagrid, and will help with performance
tuning going forward.A number of datagrid unit tests lacked any query-related assertions.
This change adds these, and in the process has uncovered some major
performance issues. These will be resolved in upcoming changes.
Unit tests pass.
Change Summary:
Added more missing datagrid tests.
Description: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+4558 -292) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
- Added docstrings to
setUp
/tearDown
- Added
num_statements=
to anassertQuery()
.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+4556 -292) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.