Summary:

Update DataGrid unit tests to use assertQueries().

Review Request #12364 — Created June 12, 2022 and submitted June 23, 2022, 2:11 p.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This enhances the datagrid unit tests to use assertQueries() instead
of assertNumQueries(). This gives us greater insight into the queries
being executed when rendering a datagrid, and will help with performance
tuning going forward.

A number of datagrid unit tests lacked any query-related assertions.
This change adds these, and in the process has uncovered some major
performance issues. These will be resolved in upcoming changes.

Testing Done

Unit tests pass.

Commits

Summary
	Update DataGrid unit tests to use assertQueries().

Screenshots

Issues

Description	From	Last Updated
This needs a docstring.	david	June 22, 2022, 3:54 p.m.
This needs a docstring.	david	June 22, 2022, 3:54 p.m.
Might be good to add num_statements= here	maubin	June 22, 2022, 3:56 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added more missing datagrid tests.

Description:

		This enhances the datagrid unit tests to use `assertQueries()` instead
		of `assertNumQueries()`. This gives us greater insight into the queries
		being executed when rendering a datagrid, and will help with performance
		tuning going forward.

		A number of datagrid unit tests lacked any query-related assertions.
		This change adds these, and in the process has uncovered some major
~		performance issues with the Users datagrid. That will be resolved in an
	~	performance issues. These will be resolved in upcoming changes.
-		upcoming change.

Commits:

	Summary
-		Update DataGrid unit tests to use assertQueries().
+		Update DataGrid unit tests to use assertQueries().

Diff:

Revision 2 (+4558 -292)

Show changes

	reviewboard/accounts/tests/test_profile.py
	reviewboard/datagrids/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/datagrids/tests.py (Diff revision 2)
Show all issues
```
This needs a docstring.
```
reviewboard/datagrids/tests.py (Diff revision 2)
Show all issues
```
This needs a docstring.
```

reviewboard/datagrids/tests.py (Diff revision 2)
Show all issues
```
Might be good to add num_statements= here
```

Change Summary:


Added docstrings to setUp/tearDown
Added num_statements= to an assertQuery().

Commits:

	Summary
-		Update DataGrid unit tests to use assertQueries().
+		Update DataGrid unit tests to use assertQueries().

Diff:

Revision 3 (+4556 -292)

Show changes

reviewboard/datagrids/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (847edda)