Update DataGrid unit tests to use assertQueries().

Review Request #12364 — Created June 12, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This enhances the datagrid unit tests to use assertQueries() instead
of assertNumQueries(). This gives us greater insight into the queries
being executed when rendering a datagrid, and will help with performance
tuning going forward.

A number of datagrid unit tests lacked any query-related assertions.
This change adds these, and in the process has uncovered some major
performance issues. These will be resolved in upcoming changes.

Unit tests pass.

Changes between revision 1 and 2

orig
1
2
3

Commits

Summary ID Author
Update DataGrid unit tests to use assertQueries().
This enhances the datagrid unit tests to use `assertQueries()` instead of `assertNumQueries()`. This gives us greater insight into the queries being executed when rendering a datagrid, and will help with performance tuning going forward. A number of datagrid unit tests lacked any query-related assertions. This change adds these, and in the process has uncovered some major performance issues with the Users datagrid. That will be resolved in an upcoming change.
40a5fcd72fee4a08b90882a278fbbf15f771c3a5 Christian Hammond
Update DataGrid unit tests to use assertQueries().
This enhances the datagrid unit tests to use `assertQueries()` instead of `assertNumQueries()`. This gives us greater insight into the queries being executed when rendering a datagrid, and will help with performance tuning going forward. A number of datagrid unit tests lacked any query-related assertions. This change adds these, and in the process has uncovered some major performance issues. These will be resolved in upcoming changes.
1dc60207caf63c24be3ecd1121ba4825fd533e10 Christian Hammond
reviewboard/accounts/tests/test_profile.py
reviewboard/datagrids/tests.py
Loading...