Summary:

Remove JOINs for starred item existence checks.

Review Request #12356 — Created June 10, 2022 and submitted June 21, 2022, 4:47 p.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This updates Profile.is_review_group_starred() and
Profile.is_review_request_starred() to avoid a JOIN when checking for
the existence of starred items. We now use the through table to
perform our check, avoiding the need to JOIN the Profile to the table.

Testing Done

Unit tests pass.

Commits

Summary
	Remove JOINs for starred item existence checks.

Screenshots

Issues

Description	From	Last Updated

flake8 passed.

JSHint passed.

Change Summary:

Removed double Q(Q(...)), now that Djblets filters this out.

Commits:

	Summary
-		Remove JOINs for starred item existence checks.
+		Remove JOINs for starred item existence checks.

Diff:

Revision 2 (+72 -116)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_profile.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (abbf3b8)