Summary

Remove JOINs for starred item existence checks.

Review Request #12356 — Created June 11, 2022 and submitted June 21, 2022, 11:47 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates Profile.is_review_group_starred() and
Profile.is_review_request_starred() to avoid a JOIN when checking for
the existence of starred items. We now use the through table to
perform our check, avoiding the need to JOIN the Profile to the table.

Testing Done

Unit tests pass.

Commits

Summary	ID
Remove JOINs for starred item existence checks. This updates `Profile.is_review_group_starred() and `Profile.is_review_request_starred()` to avoid a JOIN when checking for the existence of starred items. We now use the `through` table to perform our check, avoiding the need to JOIN the `Profile` to the table.	d8b6f651a9008022c4e1f285ee3f702bf7c907c9

flake8 passed.

JSHint passed.

Change Summary:

Removed double Q(Q(...)), now that Djblets filters this out.

Commits:

	Summary	ID
	Remove JOINs for starred item existence checks. This updates `Profile.is_review_group_starred() and `Profile.is_review_request_starred()` to avoid a JOIN when checking for the existence of starred items. We now use the `through` table to perform our check, avoiding the need to JOIN the `Profile` to the table.	b380c55d4c0f9a248488fa368d4a1335f9c98b7a
	Remove JOINs for starred item existence checks. This updates `Profile.is_review_group_starred() and `Profile.is_review_request_starred()` to avoid a JOIN when checking for the existence of starred items. We now use the `through` table to perform our check, avoiding the need to JOIN the `Profile` to the table.	d8b6f651a9008022c4e1f285ee3f702bf7c907c9

Diff:

Revision 2 (+72 -116)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_profile.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (abbf3b8)