Summary

Eliminate JOINs when determining LocalSite user membership.

Review Request #12351 — Created June 10, 2022 and submitted June 16, 2022, 7:09 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates the new User.get_local_site_stats() method to avoid
having to perform JOINs between a User and a LocalSite by way of
users or admins. We now use the through tables instead to build
the query. This simplifies the queries and allows the database to more
easily make use of the indexes established on these tables.

Testing Done

Unit tests pass.

Commits

Summary	ID
Eliminate JOINs when determining LocalSite user membership. This updates the new `User.get_local_site_stats()` method to avoid having to perform JOINs between a `User` and a `LocalSite` by way of `users` or `admins`. We now use the `through` tables instead to build the query. This simplifies the queries and allows the database to more easily make use of the indexes established on these tables.	b55ffb4bb91f7750ac587b89a46a41cafc3de1aa

flake8 passed.

JSHint passed.

Change Summary:

Removed the tables options in assertQueries() when just comparing against the model's default table.

Commits:

	Summary	ID
	Eliminate JOINs when determining LocalSite user membership. This updates the new `User.get_local_site_stats()` method to avoid having to perform JOINs between a `User` and a `LocalSite` by way of `users` or `admins`. We now use the `through` tables instead to build the query. This simplifies the queries and allows the database to more easily make use of the indexes established on these tables.	814234dfed11d6b13a0a9bcc0786e5bd295c5442
	Eliminate JOINs when determining LocalSite user membership. This updates the new `User.get_local_site_stats()` method to avoid having to perform JOINs between a `User` and a `LocalSite` by way of `users` or `admins`. We now use the `through` tables instead to build the query. This simplifies the queries and allows the database to more easily make use of the indexes established on these tables.	b55ffb4bb91f7750ac587b89a46a41cafc3de1aa

Diff:

Revision 2 (+118 -326)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_user.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (0ef1b9c)