Summary

Eliminate JOINs when counting starred objects using LocalSite.ALL.

Review Request #12349 — Created June 9, 2022 and submitted June 16, 2022, 7:08 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This improves performance of starred review group and review request
counting when using LocalSite.ALL. Since we don't need to filter by
any Profile state in this case, we can simplify things by querying the
through table the starred items, filtering by the Profile's ID.

This is much faster, as we don't need to JOIN any tables and the
database can more easily leverage the existing indexes.

Upcoming changes to use LocalSite.objects.has_local_sites() will allow
us to short-cut the queries further in the common case of no Local
Sites, avoiding the JOINs on the majority of servers.

Testing Done

Unit tests pass.

Commits

Summary	ID
Eliminate JOINs when counting review requests using LocalSite.ALL. This improves performance of starred review group and review request counting when using `LocalSite.ALL`. Since we don't need to filter by any `Profile` state in this case, we can simplify things by querying the `through` table the starred items, filtering by the `Profile`'s ID. This is much faster, as we don't need to JOIN any tables and the database can more easily leverage the existing indexes. Upcoming changes to use `LocalSite.objects.has_local_sites()` will allow us to short-cut the queries further in the common case of no Local Sites, avoiding the JOINs on the majority of servers.	990eea65964e9664b869dfad06d1b5281f0195a1

Summary

Eliminate JOINs when counting review requests using LocalSite.ALL.

This improves performance of starred review group and review request counting when using `LocalSite.ALL`. Since we don't need to filter by any `Profile` state in this case, we can simplify things by querying the `through` table the starred items, filtering by the `Profile`'s ID. This is much faster, as we don't need to JOIN any tables and the database can more easily leverage the existing indexes. Upcoming changes to use `LocalSite.objects.has_local_sites()` will allow us to short-cut the queries further in the common case of no Local Sites, avoiding the JOINs on the majority of servers.

990eea65964e9664b869dfad06d1b5281f0195a1

flake8 passed.

JSHint passed.

Change Summary:

Removed the tables options in assertQueries() when just comparing against the model's default table.

Summary:

-	Eliminate JOINs when counting review requests using LocalSite.ALL.
+	Eliminate JOINs when counting starred objects using LocalSite.ALL.

Commits:

	Summary	ID
	Eliminate JOINs when counting review requests using LocalSite.ALL. This improves performance of starred review group and review request counting when using `LocalSite.ALL`. Since we don't need to filter by any `Profile` state in this case, we can simplify things by querying the `through` table the starred items, filtering by the `Profile`'s ID. This is much faster, as we don't need to JOIN any tables and the database can more easily leverage the existing indexes. Upcoming changes to use `LocalSite.objects.has_local_sites()` will allow us to short-cut the queries further in the common case of no Local Sites, avoiding the JOINs on the majority of servers.	0ec19ab1e3e30a9d8334fdf4170df6572c4dd87d
	Eliminate JOINs when counting review requests using LocalSite.ALL. This improves performance of starred review group and review request counting when using `LocalSite.ALL`. Since we don't need to filter by any `Profile` state in this case, we can simplify things by querying the `through` table the starred items, filtering by the `Profile`'s ID. This is much faster, as we don't need to JOIN any tables and the database can more easily leverage the existing indexes. Upcoming changes to use `LocalSite.objects.has_local_sites()` will allow us to short-cut the queries further in the common case of no Local Sites, avoiding the JOINs on the majority of servers.	990eea65964e9664b869dfad06d1b5281f0195a1

Diff:

Revision 2 (+72 -190)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_profile.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (b9ea864)