• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Update Profile unit tests to use the new assertQueries() method.
    
 
    

    



 
    
 
    

  Review Request #12348
  —
  Created June 9, 2022 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-5.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Profile has recently had a number of optimizations, and there may be
    
more to come. To help ensure optimizations are having an effect on query
    
complexity, this change updates all the tests to use the new
    
assertQueries() in Djblets instead of assertNumQueries().
    

    This lets us check the specifics of the queries, including details on
    
JOINs, annotations, fields that are queried, and more. Further
    
improvements to this functionality will be more easily verified through
    
unit test changes and in code reviews.
    
 
    

    





  

    
 
 
    
  
    Unit tests pass.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Update Profile unit tests to use the new assertQueries() method.
      
    `Profile` has recently had a number of optimizations, and there may be
more to come. To help ensure optimizations are having an effect on query
complexity, this change updates all the tests to use the new
`assertQueries()` in Djblets instead of `assertNumQueries()`.

This lets us check the specifics of the queries, including details on
JOINs, annotations, fields that are queried, and more. Further
improvements to this functionality will be more easily verified through
unit test changes and in code reviews.
    
     
    

        		
    71646c8dc867812ff2826d259e151eae39d41737

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    

   
    

    
    





  david
 


    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



chipx86




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-5.0.x (33f4c47)