Update HostingServiceAccountManager.accessible to support LocalSite.ALL.

 






 

 


  Review Request #12338
  —
  Created June 3, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This deprecates HostingServiceAccount.objects.accessible()'s

filter_local_site option, which was sort of an inverse of the

show_all_local_sites option that some other managers had.


With the introduction of LocalSite.ALL, we no longer need these

secondary flags. This change emits a deprecation warning if this flag is

set, and then converts to LocalSite.ALL if appropriate.

 








  


 
 

  
All unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update HostingServiceAccountManager.accessible to support LocalSite.ALL.
     
This deprecates `HostingServiceAccount.objects.accessible()`'s
`filter_local_site` option, which was sort of an inverse of the
`show_all_local_sites` option that some other managers had.

With the introduction of `LocalSite.ALL`, we no longer need these
secondary flags. This change emits a deprecation warning if this flag is
set, and then converts to `LocalSite.ALL` if appropriate.

    

   
  		
  5d691197be2529664e3955420346065176d447a7
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...