Summary:

Update HostingServiceAccountManager.accessible to support LocalSite.ALL.

Review Request #12338 — Created June 3, 2022 and submitted June 8, 2022, 3:02 p.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This deprecates HostingServiceAccount.objects.accessible()'s
filter_local_site option, which was sort of an inverse of the
show_all_local_sites option that some other managers had.

With the introduction of LocalSite.ALL, we no longer need these
secondary flags. This change emits a deprecation warning if this flag is
set, and then converts to LocalSite.ALL if appropriate.

Testing Done

All unit tests pass.

Commits

Summary
	Update HostingServiceAccountManager.accessible to support LocalSite.ALL.

Screenshots

Issues

Description	From	Last Updated
F401 'django.db.models.Q' imported but unused	reviewbot	June 3, 2022, 4:28 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/managers.py (Diff revision 1)
Show all issues
```
F401 'django.db.models.Q' imported but unused
```

Change Summary:

Removed an unused import.

Commits:

	Summary
-		Update HostingServiceAccountManager.accessible to support LocalSite.ALL.
+		Update HostingServiceAccountManager.accessible to support LocalSite.ALL.

Diff:

Revision 2 (+82 -8)

Show changes

	reviewboard/hostingsvcs/managers.py
	reviewboard/scmtools/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (a2b2a43)