Ensure Repository.scmtool_id is always set.

 






 

 


  Review Request #12334
  —
  Created June 3, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates code which is instantiating repository objects

(almost entirely in unit tests) to ensure that the new scmtool_id

field is always properly set. Many of these were places where the unit

tests were instantiating the Repository model directly, instead of

using create_repository. I've fixed those up to use the helper

instead.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Ensure Repository.scmtool_id is always set.
     
This change updates code which is instantiating repository objects
(almost entirely in unit tests) to ensure that the new `scmtool_id`
field is always properly set. Many of these were places where the unit
tests were instantiating the `Repository` model directly, instead of
using `create_repository`. I've fixed those up to use the helper
instead.

Testing Done:
Ran unit tests.

    

   
  		
  781797eadc88e90ac8d5ad5ec50e2a59d3b16e0c
  David Trowbridge
 


 
  
 
 
  
   
    

     Ensure Repository.scmtool_id is always set.
     
This change updates code which is instantiating repository objects
(almost entirely in unit tests) to ensure that the new `scmtool_id`
field is always properly set. Many of these were places where the unit
tests were instantiating the `Repository` model directly, instead of
using `create_repository`. I've fixed those up to use the helper
instead.

Testing Done:
Ran unit tests.

    

   
  		
  4dc10d02b52cdbdcb12de584b886f7922b7ea240
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/management/commands/fill-database.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/models.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/registry.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/testing/testcase.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...