Ensure Repository.scmtool_id is always set.

Review Request #12334 — Created June 3, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

This change updates code which is instantiating repository objects
(almost entirely in unit tests) to ensure that the new scmtool_id
field is always properly set. Many of these were places where the unit
tests were instantiating the Repository model directly, instead of
using create_repository. I've fixed those up to use the helper
instead.

Ran unit tests.

Summary ID
Ensure Repository.scmtool_id is always set.
This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.
4dc10d02b52cdbdcb12de584b886f7922b7ea240
Description From Last Updated

F841 local variable 'tool_names' is assigned to but never used

reviewbotreviewbot

While here, can we have this use update_fields=?

chipx86chipx86

Let's move path to the next line, to be consistent.

chipx86chipx86

While here, let's move path to the next line.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
david
chipx86
  1. 
      
  2. While here, can we have this use update_fields=?

  3. Let's move path to the next line, to be consistent.

  4. reviewboard/reviews/tests/test_default_reviewer.py (Diff revision 3)
     
     
     
     
     
     
     

    While here, let's move path to the next line.

  5. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (de5a35e)
Loading...