Summary

Ensure Repository.scmtool_id is always set.

Review Request #12334 — Created June 3, 2022 and submitted June 13, 2022, 3:16 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates code which is instantiating repository objects
(almost entirely in unit tests) to ensure that the new scmtool_id
field is always properly set. Many of these were places where the unit
tests were instantiating the Repository model directly, instead of
using create_repository. I've fixed those up to use the helper
instead.

Testing Done

Ran unit tests.

Commits

Summary	ID
Ensure Repository.scmtool_id is always set. This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.	4dc10d02b52cdbdcb12de584b886f7922b7ea240

Summary

Ensure Repository.scmtool_id is always set.

This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.

4dc10d02b52cdbdcb12de584b886f7922b7ea240

Issues

Description	From	Last Updated
F841 local variable 'tool_names' is assigned to but never used	reviewbot	June 3, 2022, 10:30 a.m.
While here, can we have this use update_fields=?	chipx86	June 13, 2022, 3:07 p.m.
Let's move path to the next line, to be consistent.	chipx86	June 13, 2022, 3:07 p.m.
While here, let's move path to the next line.	chipx86	June 13, 2022, 3:08 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/repository.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F841 local variable 'tool_names' is assigned to but never used
```

Commits:

	Summary	ID
	Ensure Repository.scmtool_id is always set. This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.	c7612e0bd34d0909009f681947dd80ac6a1fe505
	Ensure Repository.scmtool_id is always set. This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.	781797eadc88e90ac8d5ad5ec50e2a59d3b16e0c

Diff:

Revision 2 (+556 -314)

Show changes

	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/hostingsvcs/tests/test_assembla.py
	reviewboard/hostingsvcs/tests/test_hosting_service_auth_form.py
	reviewboard/reviews/management/commands/fill-database.py
	reviewboard/reviews/tests/test_counters.py
	reviewboard/reviews/tests/test_default_reviewer.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py
	14 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Ensure Repository.scmtool_id is always set. This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.	781797eadc88e90ac8d5ad5ec50e2a59d3b16e0c
	Ensure Repository.scmtool_id is always set. This change updates code which is instantiating repository objects (almost entirely in unit tests) to ensure that the new `scmtool_id` field is always properly set. Many of these were places where the unit tests were instantiating the `Repository` model directly, instead of using `create_repository`. I've fixed those up to use the helper instead. Testing Done: Ran unit tests.	4dc10d02b52cdbdcb12de584b886f7922b7ea240

Diff:

Revision 3 (+556 -314)

Show changes

	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/hostingsvcs/tests/test_assembla.py
	reviewboard/hostingsvcs/tests/test_hosting_service_auth_form.py
	reviewboard/reviews/management/commands/fill-database.py
	reviewboard/reviews/tests/test_counters.py
	reviewboard/reviews/tests/test_default_reviewer.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/models.py
	14 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/diffviewer/tests/test_forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
While here, can we have this use update_fields=?
```
reviewboard/reviews/management/commands/fill-database.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Let's move path to the next line, to be consistent.
```
reviewboard/reviews/tests/test_default_reviewer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
While here, let's move path to the next line.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (de5a35e)