Summary:

Support passing LocalSite.ANY to Profile starred cache count functions.

Review Request #12329 — Created June 2, 2022 and submitted June 8, 2022, 3:02 p.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This updates the following methods on Profile to accept
local_site=LocalSite.ALL:

get_starred_review_groups_count()
get_starred_review_requests_count()
has_starred_review_groups()
has_starred_review_requests()

This can be used to make determinations as to whether a user has starred
items at all, regardless of global/local site.

When invalidating cached data, both the site (global or local) and the
ALL keys are invalidated, ensuring both are updated for the
appropriate totals.

Testing Done

Unit tests pass.

Commits

Summary
	Support passing LocalSite.ANY to Profile starred cache count functions.

Screenshots

Issues

Description	From	Last Updated
F841 local variable 'key' is assigned to but never used	reviewbot	June 2, 2022, 4:17 a.m.
F841 local variable 'local_site' is assigned to but never used	reviewbot	June 2, 2022, 4:17 a.m.
F841 local variable 'local_site' is assigned to but never used	reviewbot	June 2, 2022, 4:17 a.m.
F841 local variable 'local_site' is assigned to but never used	reviewbot	June 2, 2022, 4:17 a.m.
F841 local variable 'local_site' is assigned to but never used	reviewbot	June 2, 2022, 4:17 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/models.py (Diff revision 1)

Show all issues

F841 local variable 'key' is assigned to but never used

reviewboard/accounts/tests/test_profile.py (Diff revision 1)
Show all issues
```
F841 local variable 'local_site' is assigned to but never used
```
reviewboard/accounts/tests/test_profile.py (Diff revision 1)
Show all issues
```
F841 local variable 'local_site' is assigned to but never used
```
reviewboard/accounts/tests/test_profile.py (Diff revision 1)
Show all issues
```
F841 local variable 'local_site' is assigned to but never used
```
reviewboard/accounts/tests/test_profile.py (Diff revision 1)
Show all issues
```
F841 local variable 'local_site' is assigned to but never used
```

Change Summary:

Removed unused variables.

Commits:

	Summary
-		Support passing LocalSite.ANY to Profile starred cache count functions.
+		Support passing LocalSite.ANY to Profile starred cache count functions.

Diff:

Revision 2 (+1678 -166)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_profile.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (a2f7005)