Fix VersionVault directory diffing to handle added/deleted directories.

Review Request #12320 — Created June 1, 2022 and submitted

Information

RBTools
release-3.x

Reviewers

The directory diffing phase in the VersionVault client exists in order to
properly get change type and metadata for added, deleted, or renamed files. This
was hitting problems with added or deleted directories, adding them as
additional changed files. These would then get added to the diff with garbage
diff content and bad paths. This change updates the directory diffing to only
add things to the file list if they are actually files.

Set up a UCM activity with added, nested directories. Saw that the resulting
rbt diff output only included the changed files.

Summary ID
Fix VersionVault directory diffing to handle added/deleted directories.
The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.
0c2b5fdb9ae94e041cd061ccab302b446fd50359
Description From Last Updated

E501 line too long (80 > 79 characters)

reviewbotreviewbot

Blank line between these.

chipx86chipx86

Can this fail or be None?

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. 
      
  2. rbtools/clients/clearcase.py (Diff revision 2)
     
     
     
    Show all issues

    Blank line between these.

  3. rbtools/clients/clearcase.py (Diff revision 2)
     
     
     
    Show all issues

    Can this fail or be None?

    1. Not at this stage. If we get here and suddenly this one fails, something catastrophic has happened in the middle of the run.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (7f141b0)