Summary

Fix VersionVault directory diffing to handle added/deleted directories.

Review Request #12320 — Created June 1, 2022 and submitted June 8, 2022, 8:56 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The directory diffing phase in the VersionVault client exists in order to
properly get change type and metadata for added, deleted, or renamed files. This
was hitting problems with added or deleted directories, adding them as
additional changed files. These would then get added to the diff with garbage
diff content and bad paths. This change updates the directory diffing to only
add things to the file list if they are actually files.

Testing Done

Set up a UCM activity with added, nested directories. Saw that the resulting
rbt diff output only included the changed files.

Commits

Summary	ID
Fix VersionVault directory diffing to handle added/deleted directories. The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.	0c2b5fdb9ae94e041cd061ccab302b446fd50359

Summary

Fix VersionVault directory diffing to handle added/deleted directories.

The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.

0c2b5fdb9ae94e041cd061ccab302b446fd50359

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	June 1, 2022, 9:53 a.m.
Blank line between these.	chipx86	June 2, 2022, 9 a.m.
Can this fail or be None?	chipx86	June 2, 2022, 8:56 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary	ID
	Fix VersionVault directory diffing to handle added/deleted directories. The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.	f682a53e25535c15f0d439bccf02e13ead72860f
	Fix VersionVault directory diffing to handle added/deleted directories. The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.	df88a8cedef1a4858cd60ba536ae3cf7d7915332

Branch:

master

release-3.x

Diff:

Revision 2 (+90 -60)

Show changes

rbtools/clients/clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/clearcase.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line between these.
```

rbtools/clients/clearcase.py (Diff revision 2)

The issue has been dropped. Show all issues

Can this fail or be None?

david June 2, 2022, 9 a.m.

Not at this stage. If we get here and suddenly this one fails, something catastrophic has happened in the middle of the run.

Commits:

	Summary	ID
	Fix VersionVault directory diffing to handle added/deleted directories. The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.	df88a8cedef1a4858cd60ba536ae3cf7d7915332
	Fix VersionVault directory diffing to handle added/deleted directories. The directory diffing phase in the VersionVault client exists in order to properly get change type and metadata for added, deleted, or renamed files. This was hitting problems with added or deleted directories, adding them as additional changed files. These would then get added to the diff with garbage diff content and bad paths. This change updates the directory diffing to only add things to the file list if they are actually files. Testing Done: Set up a UCM activity with added, nested directories. Saw that the resulting `rbt diff` output only included the changed files.	0c2b5fdb9ae94e041cd061ccab302b446fd50359

Diff:

Revision 3 (+92 -60)

Show changes

rbtools/clients/clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (7f141b0)