Summary

Fix and improve loading of cached profiles in User.

Review Request #12318 — Created May 31, 2022 and submitted June 8, 2022, 3:01 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

User.get_profile() attempts to cache or make use of a cached result
from a previous call. It used to make use of _profile_set_cache, which
was the name used in Django 1.6 and 1.11. Newer versions use different
mechanisms for cache, for both prefetch_related() and
select_related(). This was a regression from Review Board 4.

This change fixes that support and expands upon it. A new series of unit
tests have been added that ensure caching works exactly as expected in a
variety of situations.

As part of this, various datagrid unit tests have been updated to once
again have reduced query counts. These counts were initially increased
in commit ceab149f415ade7432a3ff6e625beb0cdc5645f2, thought to have been
due to middleware changes, but were actually due to the Django relation
caching changes.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix and improve loading of cached profiles in User. `User.get_profile()` attempts to cache or make use of a cached result from a previous call. It used to make use of `_profile_set_cache`, which was the name used in Django 1.6 and 1.11. Newer versions use different mechanisms for cache, for both `prefetch_related()` and `select_related()`. This was a regression from Review Board 4. This change fixes that support and expands upon it. A new series of unit tests have been added that ensure caching works exactly as expected in a variety of situations. As part of this, various datagrid unit tests have been updated to once again have reduced query counts. These counts were initially increased in commit ceab149f415ade7432a3ff6e625beb0cdc5645f2, thought to have been due to middleware changes, but were actually due to the Django relation caching changes.	d0f07b574c0896686d6980a02f962f2d190e3e98

Summary

Fix and improve loading of cached profiles in User.

`User.get_profile()` attempts to cache or make use of a cached result from a previous call. It used to make use of `_profile_set_cache`, which was the name used in Django 1.6 and 1.11. Newer versions use different mechanisms for cache, for both `prefetch_related()` and `select_related()`. This was a regression from Review Board 4. This change fixes that support and expands upon it. A new series of unit tests have been added that ensure caching works exactly as expected in a variety of situations. As part of this, various datagrid unit tests have been updated to once again have reduced query counts. These counts were initially increased in commit ceab149f415ade7432a3ff6e625beb0cdc5645f2, thought to have been due to middleware changes, but were actually due to the Django relation caching changes.

d0f07b574c0896686d6980a02f962f2d190e3e98

Issues

Description	From	Last Updated
F841 local variable 'profile' is assigned to but never used	reviewbot	May 31, 2022, 10:11 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/tests/test_user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'profile' is assigned to but never used
```

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Fix and improve loading of cached profiles in User. `User.get_profile()` attempts to cache or make use of a cached result from a previous call. It used to make use of `_profile_set_cache`, which was the name used in Django 1.6 and 1.11. Newer versions use different mechanisms for cache, for both `prefetch_related()` and `select_related()`. This was a regression from Review Board 4. This change fixes that support and expands upon it. A new series of unit tests have been added that ensure caching works exactly as expected in a variety of situations. As part of this, various datagrid unit tests have been updated to once again have reduced query counts. These counts were initially increased in commit ceab149f415ade7432a3ff6e625beb0cdc5645f2, thought to have been due to middleware changes, but were actually due to the Django relation caching changes.	e8ef546de63c01c2a77296e5efbc7f7455655d1d
	Fix and improve loading of cached profiles in User. `User.get_profile()` attempts to cache or make use of a cached result from a previous call. It used to make use of `_profile_set_cache`, which was the name used in Django 1.6 and 1.11. Newer versions use different mechanisms for cache, for both `prefetch_related()` and `select_related()`. This was a regression from Review Board 4. This change fixes that support and expands upon it. A new series of unit tests have been added that ensure caching works exactly as expected in a variety of situations. As part of this, various datagrid unit tests have been updated to once again have reduced query counts. These counts were initially increased in commit ceab149f415ade7432a3ff6e625beb0cdc5645f2, thought to have been due to middleware changes, but were actually due to the Django relation caching changes.	d0f07b574c0896686d6980a02f962f2d190e3e98

Diff:

Revision 2 (+514 -38)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_user.py
	reviewboard/datagrids/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (ee0f51e)