Summary

Split reviewboard.site.tests into multiple test modules.

Review Request #12300 — Created May 24, 2022 and submitted May 26, 2022, 12:17 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

reviewboard.site.tests was getting a bit big, covering many areas of

Local Sites. With some new tests coming, it seemed time to split this

up.
This creates a series of new test cases for different areas of the app,

moving tests into them. The tests themselves have not changed, aside

from the removal of the old import reviewboard.site.templatetags hack

for our {% url %} replacement, which is not needed with modern Django

template configuration.
One test for managing OAuth2 Application access when Local Site

membership changes has been moved into reviewboard/oauth/tests.py.

Testing Done

Unit tests pass.

Commits

Summary	ID
Split reviewboard.site.tests into multiple test modules. `reviewboard.site.tests` was getting a bit big, covering many areas of Local Sites. With some new tests coming, it seemed time to split this up. This creates a series of new test cases for different areas of the app, moving tests into them. The tests themselves have not changed, aside from the removal of the old `import reviewboard.site.templatetags` hack for our `{% url %}` replacement, which is not needed with modern Django template configuration. One test for managing OAuth2 Application access when Local Site membership changes has been moved into `reviewboard/oauth/tests.py`.	9ba156fee3abfb650d056eecee447e7b7ca70258

Summary

Split reviewboard.site.tests into multiple test modules.

`reviewboard.site.tests` was getting a bit big, covering many areas of Local Sites. With some new tests coming, it seemed time to split this up. This creates a series of new test cases for different areas of the app, moving tests into them. The tests themselves have not changed, aside from the removal of the old `import reviewboard.site.templatetags` hack for our `{% url %}` replacement, which is not needed with modern Django template configuration. One test for managing OAuth2 Application access when Local Site membership changes has been moved into `reviewboard/oauth/tests.py`.

9ba156fee3abfb650d056eecee447e7b7ca70258

Issues

Description	From	Last Updated
We can now just use super().setUp() for most of these.	david	May 26, 2022, 10:49 a.m.
Same here.	david	May 26, 2022, 10:49 a.m.
And here.	david	May 26, 2022, 10:49 a.m.
Module docstring.	david	May 26, 2022, 12:17 p.m.

flake8 passed.

JSHint passed.

reviewboard/site/tests/test_context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We can now just use super().setUp() for most of these.
```
reviewboard/site/tests/test_local_site.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/site/tests/test_local_site_middleware.py (Diff revision 1)
The issue has been resolved. Show all issues
```
And here.
```

Change Summary:

Switched to the modern form of super().

Commits:

	Summary	ID
	Split reviewboard.site.tests into multiple test modules. `reviewboard.site.tests` was getting a bit big, covering many areas of Local Sites. With some new tests coming, it seemed time to split this up. This creates a series of new test cases for different areas of the app, moving tests into them. The tests themselves have not changed, aside from the removal of the old `import reviewboard.site.templatetags` hack for our `{% url %}` replacement, which is not needed with modern Django template configuration. One test for managing OAuth2 Application access when Local Site membership changes has been moved into `reviewboard/oauth/tests.py`.	07782fd2e755e690080f42a35059c66ed51089d0
	Split reviewboard.site.tests into multiple test modules. `reviewboard.site.tests` was getting a bit big, covering many areas of Local Sites. With some new tests coming, it seemed time to split this up. This creates a series of new test cases for different areas of the app, moving tests into them. The tests themselves have not changed, aside from the removal of the old `import reviewboard.site.templatetags` hack for our `{% url %}` replacement, which is not needed with modern Django template configuration. One test for managing OAuth2 Application access when Local Site membership changes has been moved into `reviewboard/oauth/tests.py`.	9ba156fee3abfb650d056eecee447e7b7ca70258

Diff:

Revision 2 (+716 -658)

Show changes

	reviewboard/oauth/tests.py
	reviewboard/site/tests/__init__.py
	reviewboard/site/tests/test_check_local_site_access_view_mixin.py
	reviewboard/site/tests/test_context_processors.py
	reviewboard/site/tests/test_local_site.py
	reviewboard/site/tests.py
	reviewboard/site/tests/test_local_site_middleware.py
	reviewboard/site/tests/test_template_tags.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/site/tests/test_local_site_middleware.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Module docstring.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (348e58e)