Fix errors in conditions JS.

Review Request #12298 — Created May 24, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

The version of Backbone we're using apparently doesn't like passing a
fat arrow function for the model constructor attribute of a new
collection. This was causing various errors to pop up when attempting to
use the conditions UI (and failures for those code paths in the
js-tests). This change updates it to use a regular function instead.

  • Ran js-tests.
  • Was able to configure a condition set for an integration in Review
    Board.
Summary ID
Fix errors in conditions JS.
The version of Backbone we're using apparently doesn't like passing a fat arrow function for the `model` constructor attribute of a new collection. This was causing various errors to pop up when attempting to use the conditions UI (and failures for those code paths in the js-tests). This change updates it to use a regular `function` instead. Testing Done: - Ran js-tests. - Was able to configure a condition set for an integration in Review Board.
b4952549fea123d30bd0d043fc9612f318ca8f8a
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (67b48f1)