Summary

Fix errors in conditions JS.

Review Request #12298 — Created May 24, 2022 and submitted May 30, 2022, 10:53 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The version of Backbone we're using apparently doesn't like passing a

fat arrow function for the model constructor attribute of a new

collection. This was causing various errors to pop up when attempting to

use the conditions UI (and failures for those code paths in the

js-tests). This change updates it to use a regular function instead.

Testing Done


Ran js-tests.
Was able to configure a condition set for an integration in Review

  Board.

Commits

Summary	ID
Fix errors in conditions JS. The version of Backbone we're using apparently doesn't like passing a fat arrow function for the `model` constructor attribute of a new collection. This was causing various errors to pop up when attempting to use the conditions UI (and failures for those code paths in the js-tests). This change updates it to use a regular `function` instead. Testing Done: - Ran js-tests. - Was able to configure a condition set for an integration in Review Board.	b4952549fea123d30bd0d043fc9612f318ca8f8a

Summary

Fix errors in conditions JS.

The version of Backbone we're using apparently doesn't like passing a fat arrow function for the `model` constructor attribute of a new collection. This was causing various errors to pop up when attempting to use the conditions UI (and failures for those code paths in the js-tests). This change updates it to use a regular `function` instead. Testing Done: - Ran js-tests. - Was able to configure a condition set for an integration in Review Board.

b4952549fea123d30bd0d043fc9612f318ca8f8a

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (67b48f1)