Summary

Support simulating file fetch errors in TestTool.

Review Request #12294 — Created May 22, 2022 and submitted May 23, 2022, 5:35 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

TestTool.get_file() now accepts special bad:file-not-found and
bad:scm-error paths that will simulate the FileNotFoundError and
SCMError exceptions, respectively. This can aid in testing against
these sorts of results without needing to spy on methods.

Testing Done

Made use of this in an upcoming change. Simulated both error types.

Commits

Summary	ID
Support simulating file fetch errors in TestTool. `TestTool.get_file()` now accepts special `bad:file-not-found` and `bad:scm-error` paths that will simulate the `FileNotFoundError` and `SCMError` exceptions, respectively. This can aid in testing against these sorts of results without needing to spy on methods.	9e50c48d637c9521f22a36da13bf9ccfba7b2eff

Issues

Description	From	Last Updated
F821 undefined name 'FileNotFoundError'	reviewbot	May 22, 2022, 5:13 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/testing/scmtool.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'FileNotFoundError'
```

Change Summary:

Added a line missed during git add -p.

Commits:

	Summary	ID
	Support simulating file fetch errors in TestTool. `TestTool.get_file()` now accepts special `bad:file-not-found` and `bad:scm-error` paths that will simulate the `FileNotFoundError` and `SCMError` exceptions, respectively. This can aid in testing against these sorts of results without needing to spy on methods.	8d932b93dc6bbc44c8613c2c840ef0312fe4d22d
	Support simulating file fetch errors in TestTool. `TestTool.get_file()` now accepts special `bad:file-not-found` and `bad:scm-error` paths that will simulate the `FileNotFoundError` and `SCMError` exceptions, respectively. This can aid in testing against these sorts of results without needing to spy on methods.	9e50c48d637c9521f22a36da13bf9ccfba7b2eff

Diff:

Revision 2 (+54 -2)

Show changes

reviewboard/testing/scmtool.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (1b2736b)