Add docstrings with version information to all evolutions.

Review Request #12290 — Created May 18, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

Review Board has had a great many database schema changes over its
lifetime, and the more we add, the harder it is to determine when a
particular change was made.

This poses a problem when trying to sort out failed evolution upgrades,
as sometimes an upgrade is attempted and rolled back with evolution
information recorded that breaks future attempts at a new upgrade. When
this happens, it takes a lot of effort to figure out what happened.

This change updates all evolutions in the codebase to have a docstring
that specifies the version in which the evolution was added. This rounds
up to the first public release (so no alphas/betas).

All upgrades are also tracked in Notion, for easy reference:

https://reviewboard.notion.site/Database-Schema-Changes-38702981914e48a3b32f2a3dc5243a5c

While here, I found a stray evolution that was never used (its contents
were incorporated into another evolution). That's been deleted.

Went through and verified the versions of each of these.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Add docstrings with version information to all evolutions.
Review Board has had a great many database schema changes over its lifetime, and the more we add, the harder it is to determine when a particular change was made. This poses a problem when trying to sort out failed evolution upgrades, as sometimes an upgrade is attempted and rolled back with evolution information recorded that breaks future attempts at a new upgrade. When this happens, it takes a lot of effort to figure out what happened. This change updates all evolutions in the codebase to have a docstring that specifies the version in which the evolution was added. This rounds up to the first public release (so no alphas/betas). All upgrades are also tracked in Notion, for easy reference: https://reviewboard.notion.site/Database-Schema-Changes-38702981914e48a3b32f2a3dc5243a5c
c7a12978959812b5af81f7b01993858fff356e45 Christian Hammond
This diff has been split across 5 pages: < 1 2 3 4 5 >
reviewboard/notifications/evolutions/manytomanyfield_rm_null.py
reviewboard/notifications/evolutions/webhooktarget_extra_data_null.py
reviewboard/notifications/evolutions/webhooktarget_extra_state.py
reviewboard/oauth/evolutions/disabled_for_security.py
reviewboard/reviews/evolutions/add_issues_to_comments.py
reviewboard/reviews/evolutions/add_owner_to_draft.py
reviewboard/reviews/evolutions/base_comment_extra_data.py
reviewboard/reviews/evolutions/change_descriptions.py
reviewboard/reviews/evolutions/comment_issue_verification.py
reviewboard/reviews/evolutions/commit_id.py
reviewboard/reviews/evolutions/default_reviewer_local_site.py
reviewboard/reviews/evolutions/default_reviewer_repositories.py
reviewboard/reviews/evolutions/extra_data.py
reviewboard/reviews/evolutions/file_attachment_comment_diff_id.py
reviewboard/reviews/evolutions/file_attachment_comment_extra_data.py
reviewboard/reviews/evolutions/file_attachments.py
reviewboard/reviews/evolutions/general_comments.py
reviewboard/reviews/evolutions/group_email_list_only.py
reviewboard/reviews/evolutions/group_incoming_request_count.py
reviewboard/reviews/evolutions/group_invite_only.py
This diff has been split across 5 pages: < 1 2 3 4 5 >
Loading...