Fix missing and premature function calls when updating the database

Review Request #12285 — Created May 16, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

Running ./contrib/internal/prepare-dev.py to prepare the development
environment failed during the database set up phase due to undefined functions
and a missing database table error during pre-upgrade tasks. This change imports
the missing functions and ensures that pre-upgrade tasks are not run too early.

Ran tests in reviewboard/cmdline/tests and successfully ran
./contrib/internal/prepare-dev.py.

Summary ID Author
imported missing functions
564ba2f9d2b052c321de19b5e220761d0f5d0443 Michelle
moved premature function call
d7d5ff1ac00491a9020721b2f79efe1ee2c049bd Michelle
Description From Last Updated

Can you please wrap the description to 80 columns?

daviddavid

A good flow for the description is to start by describing the problem that occurred (and how it was triggered), …

chipx86chipx86
david
  1. 
      
  2. Can you please wrap the description to 80 columns?

  3. 
      
maubin
chipx86
  1. 
      
  2. A good flow for the description is to start by describing the problem that occurred (and how it was triggered), and then how it was addressed. That helps particularly when building release notes later, or when performing code archaeology to track down other issues.

  3. 
      
maubin
david
  1. Ship It!
  2. 
      
maubin
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1a7581e)
Loading...