Summary:

Fix missing and premature function calls when updating the database

Review Request #12285 — Created May 16, 2022 and submitted May 20, 2022, 5:01 p.m.

Information
Owner:	maubin
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Running ./contrib/internal/prepare-dev.py to prepare the development
environment failed during the database set up phase due to undefined functions
and a missing database table error during pre-upgrade tasks. This change imports
the missing functions and ensures that pre-upgrade tasks are not run too early.

Testing Done

Ran tests in reviewboard/cmdline/tests and successfully ran
./contrib/internal/prepare-dev.py.

Commits

Summary	Author
imported missing functions	Michelle
moved premature function call	Michelle

Screenshots

Issues

Description	From	Last Updated
Can you please wrap the description to 80 columns?	david	May 17, 2022, 9:36 a.m.
A good flow for the description is to start by describing the problem that occurred (and how it was triggered), …	chipx86	May 18, 2022, 8:28 a.m.

flake8 passed.

JSHint passed.

Show all issues

Can you please wrap the description to 80 columns?

Description:

~		Imported missing functions from `reviewboard.upgrade` and ensures that pre-upgrade tasks are not run too early.
	~	Imported missing functions from `reviewboard.upgrade` and ensures that
	+	pre-upgrade tasks are not run too early.

Show all issues

A good flow for the description is to start by describing the problem that occurred (and how it was triggered), and then how it was addressed. That helps particularly when building release notes later, or when performing code archaeology to track down other issues.

Description:

~		Imported missing functions from `reviewboard.upgrade` and ensures that
~		pre-upgrade tasks are not run too early.
	~	Running `./contrib/internal/prepare-dev.py` to prepare the development
	~	environment failed during the database set up phase due to undefined functions
	+	and a missing database table error during pre-upgrade tasks. This change imports
	+	the missing functions and ensures that pre-upgrade tasks are not run too early.

Testing Done:

~		Ran tests in `reviewboard/cmdline/tests`
	~	Ran tests in `reviewboard/cmdline/tests` and successfully ran
	+	`./contrib/internal/prepare-dev.py`.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1a7581e)