Summary

Add and update compatibility functions for working with models and fields.

Review Request #12229 — Created April 8, 2022 and submitted April 8, 2022, 8:39 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

This introduces three new compatibility functions for working with fields
cross-Django:

get_field_is_relation()
get_field_is_many_to_many()
get_remote_field_related_model()

It also updates several other field-relation functions to provide more
consistent results for different fiels and relation types.

Unit tests were added for most functions in this module to help catch
inconsistencies in behavior across versions of Django.

Testing Done

Unit tests pass on all supported versions of Django.

Used the new behavior in some in-progress changes.

Commits

Summary	ID
Add and update compatibility functions for working with models and fields. This introduces three new compatibility functions for working with fields cross-Django: * `get_field_is_relation()` * `get_field_is_many_to_many()` * `get_remote_field_related_model()` It also updates several other field-relation functions to provide more consistent results for different fiels and relation types. Unit tests were added for most functions in this module to help catch inconsistencies in behavior across versions of Django.	7b72e0bbe20db49b68b1225e280754709ffbff37

Summary

Add and update compatibility functions for working with models and fields.

This introduces three new compatibility functions for working with fields cross-Django: * `get_field_is_relation()` * `get_field_is_many_to_many()` * `get_remote_field_related_model()` It also updates several other field-relation functions to provide more consistent results for different fiels and relation types. Unit tests were added for most functions in this module to help catch inconsistencies in behavior across versions of Django.

7b72e0bbe20db49b68b1225e280754709ffbff37

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	April 8, 2022, 2:07 a.m.
E303 too many blank lines (3)	reviewbot	April 8, 2022, 2:07 a.m.
E501 line too long (82 > 79 characters)	reviewbot	April 8, 2022, 2:07 a.m.
E501 line too long (80 > 79 characters)	reviewbot	April 8, 2022, 2:08 a.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/compat/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
django_evolution/tests/test_compat_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (3)
```
django_evolution/tests/test_compat_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
django_evolution/tests/test_compat_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Change Summary:


Removed an extra blank line.
Fixed line length issues.

Commits:

	Summary	ID
	Add and update compatibility functions for working with models and fields. This introduces three new compatibility functions for working with fields cross-Django: * `get_field_is_relation()` * `get_field_is_many_to_many()` * `get_remote_field_related_model()` It also updates several other field-relation functions to provide more consistent results for different fiels and relation types. Unit tests were added for most functions in this module to help catch inconsistencies in behavior across versions of Django.	cefb8975b48c04220b5a79fe08a7342385810386
	Add and update compatibility functions for working with models and fields. This introduces three new compatibility functions for working with fields cross-Django: * `get_field_is_relation()` * `get_field_is_many_to_many()` * `get_remote_field_related_model()` It also updates several other field-relation functions to provide more consistent results for different fiels and relation types. Unit tests were added for most functions in this module to help catch inconsistencies in behavior across versions of Django.	7b72e0bbe20db49b68b1225e280754709ffbff37

Diff:

Revision 2 (+826 -6)

Show changes

	django_evolution/compat/db.py
	django_evolution/compat/models.py
	django_evolution/tests/test_compat_models.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (d14b9b3)